bug#27251: [PATCH 00/27] KDE Frameworks: Add inputs, fix some tests, cleanup.

bug#27251: [PATCH 00/27] KDE Frameworks: Add inputs, fix some tests, cleanup.

[Hartmut Goebel]

This patch series for kde-frameworks.scm

 * adds (almost) all optional and recommended inputs
 * adds comments for still missing optional or recommended inputs
 * removes the requirement on xorg-server for tests where possible.
    Some packages started a x.org server for testing, which can be
    avoided by setting QT_QPA_PLATFORM=offscreen.
 * re-anables some test-suites now passing
 * retains the progress on makeing a test-suite pass (while keeping the
   still-failing test-suite disabled)


Hartmut Goebel (27):
  gnu: kguiaddons: Add more optional inputs.
  gnu: kguiaddons: Remove unused native input.
  gnu: kguiaddons: Add a todo comment.
  gnu: kitemmodels: Add more optional inputs.
  gnu: kcompletion: Remove unused native input.
  gnu: kde frameworks: Avoid requiring xorg-server for tests.
  gnu: kimageformats: Add more optional and recommended inputs.
  gnu: kio: Add more optional and recommended inputs.
  gnu: kinit: Add more optional inputs.
  gnu: ktexteditor: Add more optional inputs.
  gnu: ktexteditor: Add a todo comment.
  gnu: plasma-framework: Add more optional inputs.
  gnu: plasma-framework: Update comment (number of failed tests).
  gnu: kpackage: Add more optional inputs.
  gnu: kpackage: Update comment (number of failed tests).
  gnu: sonnet: Add optional input (spell-checker).
  gnu: gpgmepp: Superseded by gpgme.
  gnu: kwallet: Use gpgme instead of gpgmepp.
  gnu: kiconthemes: Re-enable tests.
  gnu: kwidgetsaddons: Re-enable tests.
  gnu: kwindowsystem: Fix some test-cases (test-suite still disabled).
  gnu: kdeclarative: Update comment.
  gnu: kpty: Add a todo comment.
  gnu: phonon: Add a todo comment.
  gnu: ktextwidgets: Add a todo comment.
  gnu: knotifications: Add a todo comments.
  gnu: solid: Add a todo comment.

 gnu/packages/kde-frameworks.scm | 169 +++++++++++++++++++++++++---------------
 1 file changed, 107 insertions(+), 62 deletions(-)

-- 
2.7.4

bug#27251: [PATCH 01/27] gnu: kguiaddons: Add more optional inputs.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kguiaddons)
  [native-inputs]: Add pkg-config. [inputs]:Add qtx11extras.
---
 gnu/packages/kde-frameworks.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 07943e1..d44692a 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -641,9 +641,11 @@ infrastructure.")
     (build-system cmake-build-system)
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)
        ("xorg-server" ,xorg-server)))
     (inputs
-     `(("qtbase" ,qtbase)))
+     `(("qtbase" ,qtbase)
+       ("qtx11extras" ,qtx11extras)))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-- 
2.7.4

bug#27251: [PATCH 02/27] gnu: kguiaddons: Remove unused native input.

[Hartmut Goebel]

The xorg server is not required since change
1de5b667f896aa2c612416bffac5f77cae94c5f4.

* gnu/packages/kde-frameworks.scm (kguiaddons)[native-inputs]: Remove
  xorg-server.
---
 gnu/packages/kde-frameworks.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index d44692a..f7f5598 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -641,8 +641,7 @@ infrastructure.")
     (build-system cmake-build-system)
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
-       ("pkg-config" ,pkg-config)
-       ("xorg-server" ,xorg-server)))
+       ("pkg-config" ,pkg-config)))
     (inputs
      `(("qtbase" ,qtbase)
        ("qtx11extras" ,qtx11extras)))
-- 
2.7.4

bug#27251: [PATCH 03/27] gnu: kguiaddons: Add a todo comment.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kguiaddons)[native-inputs]: Add comment.
---
 gnu/packages/kde-frameworks.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index f7f5598..dff5e25 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -639,6 +639,10 @@ infrastructure.")
                (base32
                 "1nmlwvy2jdmh0m6bmahvk68vl2rs9s28c10dkncpi6gvhsdkigqx"))))
     (build-system cmake-build-system)
+    ;; TODO: Build packages for the Python bindings.  Ideally this will be
+    ;; done for all versions of python guix supports.  Requires python,
+    ;; python-sip, clang-python, libclang.  Requires python-2 in all cases for
+    ;; clang-python.
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("pkg-config" ,pkg-config)))
-- 
2.7.4

bug#27251: [PATCH 04/27] gnu: kitemmodels: Add more optional inputs.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kitemmodels)[inputs]: Add qtdeclarative.
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index dff5e25..c756615 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -751,7 +751,8 @@ or user activity.")
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("xorg-server" ,xorg-server)))
     (inputs
-     `(("qtbase" ,qtbase)))
+     `(("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-- 
2.7.4

bug#27251: [PATCH 05/27] gnu: kcompletion: Remove unused native input.

[Hartmut Goebel]

The xorg server is not required since change
548f99b3e0d3647f29ddc3c3864ca36b655f14ec.

* gnu/packages/kde-frameworks.scm (kcompletion)[native-inputs]: Remove
  xorg-server.
---
 gnu/packages/kde-frameworks.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index c756615..4ecceb0 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1307,8 +1307,7 @@ utilities.")
     (build-system cmake-build-system)
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
-       ("qttools" ,qttools)
-       ("xorg-server" ,xorg-server)))
+       ("qttools" ,qttools)))
     (inputs
      `(("kconfig" ,kconfig)
        ("kwidgetsaddons" ,kwidgetsaddons)
-- 
2.7.4

bug#27251: [PATCH 06/27] gnu: kde frameworks: Avoid requiring xorg-server for tests.

[Hartmut Goebel]

Some packages started a x.org server for testing, which can be
avoided by setting QT_QPA_PLATFORM=offscreen.

* gnu/packages/kde-frameworks.scm (kitemmodels)
  [native-inputs]: Remove xorg-server.
  [arguments]<#phases> 'start-xorg-server' replace by 'check-setup'.
  (kplotting, kcrash, kimageformats): Likewise.
  (kitemviews)[native-inputs]: Remove xorg-server.
  [arguments]<#phases> 'start-xorg-server': Remove phase; 'check-setup':
  set QT_QPA_PLATFORM=offscreen.
---
 gnu/packages/kde-frameworks.scm | 64 +++++++++++++++--------------------------
 1 file changed, 23 insertions(+), 41 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 4ecceb0..58f9ac0 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -748,20 +748,17 @@ or user activity.")
                 "1liq1ppa7xb1dcncv25c2a0xy3l9bvb2a56cff90c0b0vwr239q5"))))
     (build-system cmake-build-system)
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)
-       ("xorg-server" ,xorg-server)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
     (inputs
      `(("qtbase" ,qtbase)
        ("qtdeclarative" ,qtdeclarative)))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-         (add-before 'check 'start-xorg-server
-           (lambda* (#:key inputs #:allow-other-keys)
-             ;; The test suite requires a running X server.
-             (system (string-append (assoc-ref inputs "xorg-server")
-                                    "/bin/Xvfb :1 &"))
-             (setenv "DISPLAY" ":1")
+         (add-before 'check 'check-setup
+           (lambda _
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
              #t)))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Set of item models extending the Qt model-view framework")
@@ -811,8 +808,7 @@ model to observers
     (build-system cmake-build-system)
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
-       ("qttools" ,qttools)
-       ("xorg-server" ,xorg-server)))
+       ("qttools" ,qttools)))
     (inputs
      `(("qtbase" ,qtbase)))
     (arguments
@@ -821,13 +817,8 @@ model to observers
          (add-before 'check 'check-setup
            (lambda _
              (setenv "DBUS_FATAL_WARNINGS" "0")
-             #t))
-         (add-before 'check 'start-xorg-server
-           (lambda* (#:key inputs #:allow-other-keys)
-             ;; The test suite requires a running X server.
-             (system (string-append (assoc-ref inputs "xorg-server")
-                                    "/bin/Xvfb :1 &"))
-             (setenv "DISPLAY" ":1")
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
              #t)))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Set of item views extending the Qt model-view framework")
@@ -851,19 +842,16 @@ to flat and hierarchical lists.")
                 "1ffy9b08128ym024wlfgnzk52vpy0mbaa91dhndpr40qcz0i67sh"))))
     (build-system cmake-build-system)
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)
-       ("xorg-server" ,xorg-server)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
     (inputs
      `(("qtbase" ,qtbase)))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-         (add-before 'check 'start-xorg-server
-           (lambda* (#:key inputs #:allow-other-keys)
-             ;; The test suite requires a running X server.
-             (system (string-append (assoc-ref inputs "xorg-server")
-                                    "/bin/Xvfb :1 &"))
-             (setenv "DISPLAY" ":1")
+         (add-before 'check 'check-setup
+           (lambda _ ; kplotting
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
              #t)))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Data plotting library")
@@ -1342,8 +1330,7 @@ integrated it into your application's other widgets.")
                 "1cshay7dhbqgh62nq85vd9sm20gq9s9f70mdnzjjh1q7cajybkp3"))))
     (build-system cmake-build-system)
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)
-       ("xorg-server" ,xorg-server)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
     (inputs
      `(("kcoreaddons" ,kcoreaddons)
        ("kwindowsystem" ,kwindowsystem)
@@ -1352,12 +1339,10 @@ integrated it into your application's other widgets.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-         (add-before 'check 'start-xorg-server
-           (lambda* (#:key inputs #:allow-other-keys)
-             ;; The test suite requires a running X server.
-             (system "Xvfb :1 &")
-             (sleep 2)              ;XXX: give the server enough time to start
-             (setenv "DISPLAY" ":1")
+         (add-before 'check 'check-setup
+           (lambda _
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
              #t)))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Graceful handling of application crashes")
@@ -1480,19 +1465,16 @@ by applications to write metadata.")
                 "0q9ng4clqk2dqw43nk1pmq1d61rahc3qr4dmg4y3kjvz3ahnnijw"))))
     (build-system cmake-build-system)
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)
-       ("xorg-server" ,xorg-server)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
     (inputs
      `(("qtbase" ,qtbase)))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-         (add-before 'check 'start-xorg-server
-           (lambda* (#:key inputs #:allow-other-keys)
-             ;; The test suite requires a running X server.
-             (system (string-append (assoc-ref inputs "xorg-server")
-                                    "/bin/Xvfb :1 &"))
-             (setenv "DISPLAY" ":1")
+         (add-before 'check 'check-setup
+           (lambda _
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
              #t)))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Plugins to allow QImage to support extra file formats")
-- 
2.7.4

bug#27251: [PATCH 07/27] gnu: kimageformats: Add more optional and recommended inputs.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kimageformats)
  [native-inputs]: Add pkg-config.
  [inputs]: Add karchive, openexr.
  [arguments]<#:configure-flags>: Set include-flags.
---
 gnu/packages/kde-frameworks.scm | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 58f9ac0..f1ae80e 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -43,6 +43,7 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages graphics)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages image)
   #:use-module (gnu packages linux)
@@ -1465,9 +1466,12 @@ by applications to write metadata.")
                 "0q9ng4clqk2dqw43nk1pmq1d61rahc3qr4dmg4y3kjvz3ahnnijw"))))
     (build-system cmake-build-system)
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
     (inputs
-     `(("qtbase" ,qtbase)))
+     `(("karchive" ,karchive) ; for Krita and OpenRaster images
+       ("openexr" ,openexr) ; for OpenEXR high dynamic-range images
+       ("qtbase" ,qtbase)))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
@@ -1475,7 +1479,14 @@ by applications to write metadata.")
            (lambda _
              ;; make Qt render "offscreen", required for tests
              (setenv "QT_QPA_PLATFORM" "offscreen")
-             #t)))))
+             #t)))
+       ;; FIXME: The header files of ilmbase (propagated by openexr) are not
+       ;; found when included by the header files of openexr, and an explicit
+       ;; flag needs to be set.
+       #:configure-flags
+       (list (string-append "-DCMAKE_CXX_FLAGS=-I"
+                            (assoc-ref %build-inputs "ilmbase")
+                            "/include/OpenEXR"))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Plugins to allow QImage to support extra file formats")
     (description "This framework provides additional image format plugins for
-- 
2.7.4

bug#27251: [PATCH 08/27] gnu: kio: Add more optional and recommended inputs.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kio)[inputs]: Add mit-krb5, qtscript.
---
 gnu/packages/kde-frameworks.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index f1ae80e..4b996fb 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -46,6 +46,7 @@
   #:use-module (gnu packages graphics)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages image)
+  #:use-module (gnu packages kerberos)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages mp3)
   #:use-module (gnu packages pdf)
@@ -2308,6 +2309,7 @@ makes starting KDE applications faster and reduces memory consumption.")
        ("extra-cmake-modules" ,extra-cmake-modules)))
     (inputs
      `(("acl" ,acl)
+       ("krb5" ,mit-krb5)
        ("karchive" ,karchive)
        ("kauth" ,kauth)
        ("kcodecs" ,kcodecs)
@@ -2324,6 +2326,7 @@ makes starting KDE applications faster and reduces memory consumption.")
        ("libxml2" ,libxml2)
        ("libxslt" ,libxslt)
        ("qtbase" ,qtbase)
+       ("qtscript" ,qtscript)
        ("qtx11extras" ,qtx11extras)
        ("sonnet" ,sonnet)))
     (arguments
-- 
2.7.4

bug#27251: [PATCH 09/27] gnu: kinit: Add more optional inputs.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kinit)
  [native-inputs]: Add pkg-config.
  [inputs]: Add kdoctools, libcap.
---
 gnu/packages/kde-frameworks.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 4b996fb..dbdf338 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2251,7 +2251,8 @@ in applications using the KDE Frameworks.")
                 "08429kjihpaip73wszr3rsii8sdlwgm3kxx7g0hpjhkj9d2jq3m1"))))
     (build-system cmake-build-system)
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
     (inputs
      `(("kauth" ,kauth)
        ("kbookmarks" ,kbookmarks)
@@ -2261,6 +2262,7 @@ in applications using the KDE Frameworks.")
        ("kconfigwidgets" ,kconfigwidgets)
        ("kcoreaddons" ,kcoreaddons)
        ("kcrash" ,kcrash)
+       ("kdoctools" ,kdoctools)
        ("kio" ,kio)
        ("kitemviews" ,kitemviews)
        ("ki18n" ,ki18n)
@@ -2269,6 +2271,7 @@ in applications using the KDE Frameworks.")
        ("kwidgetsaddons" ,kwidgetsaddons)
        ("kwindowsystem" ,kwindowsystem)
        ("kxmlgui" ,kxmlgui)
+       ("libcap" ,libcap) ; to install start_kdeinit with CAP_SYS_RESOURCE
        ("qtbase" ,qtbase)
        ("solid" ,solid)))
     (home-page "https://community.kde.org/Frameworks")
-- 
2.7.4

bug#27251: [PATCH 10/27] gnu: ktexteditor: Add more optional inputs.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (ktexteditor)[native-inputs]: Add
  pkg-config.
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index dbdf338..661ccf8 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2668,7 +2668,8 @@ types or handled by application specific code.")
     (propagated-inputs
      `(("kparts" ,kparts)))
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
     (inputs
      `(("karchive" ,karchive)
        ("kauth" ,kauth)
-- 
2.7.4

bug#27251: [PATCH 11/27] gnu: ktexteditor: Add a todo comment.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (ktexteditor)[inputs]: Add comment.
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 661ccf8..fe3393d 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2671,7 +2671,8 @@ types or handled by application specific code.")
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("pkg-config" ,pkg-config)))
     (inputs
-     `(("karchive" ,karchive)
+     `(;; TODO: editor-config
+       ("karchive" ,karchive)
        ("kauth" ,kauth)
        ("kbookmarks" ,kbookmarks)
        ("kcodecs" ,kcodecs)
-- 
2.7.4

bug#27251: [PATCH 12/27] gnu: plasma-framework: Add more optional inputs.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (plasma-frameworks)[native-inputs]: Add
  pkg-config. [inputs]: Add kwayland.
---
 gnu/packages/kde-frameworks.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index fe3393d..fe57bce 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2921,7 +2921,8 @@ setUrl, setUserAgent and call.")
      `(("kpackage" ,kpackage)
        ("kservice" ,kservice)))
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
     (inputs
      `(("kactivities" ,kactivities)
        ("karchive" ,karchive)
@@ -2943,6 +2944,7 @@ setUrl, setUserAgent and call.")
        ("ki18n" ,ki18n)
        ("kjobwidgets" ,kjobwidgets)
        ("knotificantions" ,knotifications)
+       ("kwayland" ,kwayland)
        ("kwidgetsaddons" ,kwidgetsaddons)
        ("kwindowsystem" ,kwindowsystem)
        ("kxmlgui" ,kxmlgui)
-- 
2.7.4

bug#27251: [PATCH 13/27] gnu: plasma-framework: Update comment (number of failed tests).

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (plasma-framework)[arguments]: Change
  comment.
---
 gnu/packages/kde-frameworks.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index fe57bce..d2658f2 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2955,7 +2955,7 @@ setUrl, setUserAgent and call.")
        ("qtx11extras" ,qtx11extras)
        ("solid" ,solid)))
     (arguments
-     `(#:tests? #f ; FIXME: 13/14 tests fail.
+     `(#:tests? #t ; FIXME: 9/15 tests fail.
        #:phases
        (modify-phases %standard-phases
          (add-before 'check 'check-setup
-- 
2.7.4

bug#27251: [PATCH 14/27] gnu: kpackage: Add more optional inputs.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kpackage)[inputs]: Add kdoctools.
---
 gnu/packages/kde-frameworks.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index d2658f2..e114f45 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1587,6 +1587,7 @@ covers feedback and persistent events.")
      `(("karchive" ,karchive)
        ("kconfig" ,kconfig)
        ("kcoreaddons" ,kcoreaddons)
+       ("kdoctools" ,kdoctools)
        ("ki18n" ,ki18n)
        ("qtbase" ,qtbase)))
     (arguments
-- 
2.7.4

bug#27251: [PATCH 15/27] gnu: kpackage: Update comment (number of failed tests).

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kpackage)[arguments]: Change comment.
---
 gnu/packages/kde-frameworks.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index e114f45..6c178b7 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1591,7 +1591,7 @@ covers feedback and persistent events.")
        ("ki18n" ,ki18n)
        ("qtbase" ,qtbase)))
     (arguments
-     `(#:tests? #f ; FIXME: 1/4 tests fail.
+     `(#:tests? #f ; FIXME: 3/9 tests fail.
        #:phases
        (modify-phases %standard-phases
          (add-before 'check 'check-setup
-- 
2.7.4

bug#27251: [PATCH 16/27] gnu: sonnet: Add optional input (spell-checker).

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (sonnet)[inputs]: Add hunspell; add
  todo comment for other language's spell-checker.
---
 gnu/packages/kde-frameworks.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 6c178b7..2535a38 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -47,6 +47,7 @@
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages image)
   #:use-module (gnu packages kerberos)
+  #:use-module (gnu packages libreoffice)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages mp3)
   #:use-module (gnu packages pdf)
@@ -1196,7 +1197,9 @@ system.")
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("qttools" ,qttools)))
     (inputs
-     `(("qtbase" ,qtbase)))
+     `(("hunspell" ,hunspell)
+       ;; TODO: hspell (for Hebrew), Voikko (for Finish)
+       ("qtbase" ,qtbase)))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Multi-language spell checker")
     (description "Sonnet is a plugin-based spell checking library for Qt-based
-- 
2.7.4

bug#27251: [PATCH 17/27] gnu: gpgmepp: Superseded by gpgme.

[Hartmut Goebel]

The C++-bindings are part of gpgme since version 1.7.

* gnu/packages/kde-frameworks.scm (gpgmepp)[properties]: New field.
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 2535a38..323b125 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -205,7 +205,8 @@ Phonon-GStreamer is a backend based on the GStreamer multimedia library.")
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "C++ bindings/wrapper for gpgme")
     (description "C++ bindings/wrapper for gpgme.")
-    (license license:lgpl2.1+)))
+    (license license:lgpl2.1+)
+    (properties `((superseded . ,gpgme)))))
 
 (define-public kpmcore
   (package
-- 
2.7.4

bug#27251: [PATCH 18/27] gnu: kwallet: Use gpgme instead of gpgmepp.

[Hartmut Goebel]

The C++-bindings are part of gpgme since version 1.7.

* gnu/packages/kde-frameworks.scm(kwallet)[inputs]: Replace gpgmepp by
  gpgme.
---
 gnu/packages/kde-frameworks.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 323b125..73215a1 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2789,7 +2789,7 @@ It supports rich text as well as plain text.")
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)))
     (inputs
-     `(("gpgmepp" ,gpgmepp)
+     `(("gpgme" ,gpgme) ;; TODO: Add gpgme Qt-bindings
        ("kauth" ,kauth)
        ("kcodecs" ,kcodecs)
        ("kconfig" ,kconfig)
-- 
2.7.4

bug#27251: [PATCH 19/27] gnu: kiconthemes: Re-enable tests.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kiconthemes)[arguments]: Test-suite
  is now passing; reenable it.
---
 gnu/packages/kde-frameworks.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 73215a1..21eae69 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2223,8 +2223,7 @@ window does not need focus for them to be activated.")
        ("qtbase" ,qtbase)
        ("qtsvg" ,qtsvg)))
     (arguments
-     `(#:tests? #f ; FIXME: Test failure
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          (add-before 'check 'check-setup
            (lambda* (#:key inputs #:allow-other-keys)
-- 
2.7.4

bug#27251: [PATCH 20/27] gnu: kwidgetsaddons: Re-enable tests.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kwidgetsaddons)[arguments]: Test-suite
   is now passing; reenable it.
---
 gnu/packages/kde-frameworks.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 21eae69..abedcff 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -974,8 +974,7 @@ represented by a QPoint or a QSize.")
     (inputs
      `(("qtbase" ,qtbase)))
     (arguments
-     `(#:tests? #f ; FIXME: Regression after update to qt 5.7
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          (add-before 'check 'check-setup
            (lambda _
-- 
2.7.4

bug#27251: [PATCH 21/27] gnu: kwindowsystem: Fix some test-cases (test-suite still disabled).

[Hartmut Goebel]

Make five tests pass, three are still failing – thus the test-suite is still
disabled. This commit's aim is to retain the progress.

* gnu/packages/kde-frameworks.scm (kwindowsystem)[native-inputs]: Add dbus.
  [arguments]<#:test?>: Change comment. <#:phases>: Replace phase `check` by
  new one befind 'install'.
---
 gnu/packages/kde-frameworks.scm | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index abedcff..1d1c3f2 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1017,6 +1017,7 @@ configuration pages, message boxes, and password requests.")
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("pkg-config" ,pkg-config)
+       ("dbus" ,dbus) ; for the tests
        ("qttools" ,qttools)
        ("xorg-server" ,xorg-server))) ; for the tests
     (inputs
@@ -1025,7 +1026,31 @@ configuration pages, message boxes, and password requests.")
        ("qtx11extras" ,qtx11extras)
        ("xcb-utils-keysyms" ,xcb-util-keysyms)))
     (arguments
-     `(#:tests? #f)) ; FIXME: 8/10 tests fail.
+     `(#:tests? #f ; FIXME: 3/12 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'check)
+         (add-after 'install 'check
+           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+             ;; TODO: Simplify and use "common" phases when test-suite passes
+             (if tests?
+                 (begin
+                   (let ((out (assoc-ref outputs "out")))
+                     (setenv "QT_PLUGIN_PATH"
+                             (string-append out "/lib/plugins:"
+                                            (getenv "QT_PLUGIN_PATH"))))
+                   ;; The test suite requires a running X server, setting
+                   ;; QT_QPA_PLATFORM=offscreen does not suffice and even make
+                   ;; some tests fail.
+                   (system (string-append (assoc-ref inputs "xorg-server")
+                                          "/bin/Xvfb :1 -screen 0 640x480x24 &"))
+                   (setenv "DISPLAY" ":1")
+                   (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
+                   (setenv "DBUS_FATAL_WARNINGS" "0")
+                   (zero? (system* "dbus-launch" "ctest" ".")))
+                 (begin
+                   (format #t "test suite not run~%")
+                   #t)))))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "KDE access to the windowing system")
     (description "KWindowSystem provides information about and allows
-- 
2.7.4

bug#27251: [PATCH 22/27] gnu: kdeclarative: Update comment.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kdeclarative): Update comment.
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 1d1c3f2..04b9f5d 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2017,7 +2017,8 @@ their settings.")
        (modify-phases %standard-phases
          (add-before 'check 'start-xorg-server
            (lambda* (#:key inputs #:allow-other-keys)
-             ;; The test suite requires a running X server.
+             ;; The test suite requires a running X server, setting
+             ;; QT_QPA_PLATFORM=offscreen does not suffice.
              (system (string-append (assoc-ref inputs "xorg-server")
                                     "/bin/Xvfb :1 -screen 0 640x480x24 &"))
              (setenv "DISPLAY" ":1")
-- 
2.7.4

bug#27251: [PATCH 23/27] gnu: kpty: Add a todo comment.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kpty)[inputs]: Add a todo comment.
---
 gnu/packages/kde-frameworks.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 04b9f5d..ea37a75 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1652,6 +1652,7 @@ were traditional plugins.")
     (inputs
      `(("kcoreaddons" ,kcoreaddons)
        ("ki18n" ,ki18n)
+       ;; TODO: utempter, for managing UTMP entries
        ("qtbase" ,qtbase)))
     (arguments
      `(#:tests? #f ; FIXME: 1/1 tests fail.
-- 
2.7.4

bug#27251: [PATCH 24/27] gnu: phonon: Add a todo comment.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (phonon)[native-inputs]: Add comment.
---
 gnu/packages/kde-frameworks.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index ea37a75..e990980 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -123,6 +123,8 @@ common build settings used in software produced by the KDE community.")
                 "177647r2jqfm32hqcz2nqfqv6v48hn5ab2vc31svba2wz23fkgk7"))))
     (build-system cmake-build-system)
     (native-inputs
+     ;; TODO: Add qttools to build the Qt Designer plugin.
+     ;; TODO: Think about adding pulseaudio. Is it required for sound?
      `(("extra-cmake-modules" ,extra-cmake-modules)))
     (inputs
      `(("qtbase" ,qtbase)))
-- 
2.7.4

bug#27251: [PATCH 25/27] gnu: ktextwidgets: Add a todo comment.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (ktextwidgets)[inputs]: Add comment.
---
 gnu/packages/kde-frameworks.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index e990980..c60bb85 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2783,6 +2783,7 @@ library.")
        ("kservice" ,kservice)
        ("kwidgetsaddons" ,kwidgetsaddons)
        ("kwindowsystem" ,kwindowsystem)
+       ;; TODO: qtspeech (new in Qt 5.9)
        ("qtbase" ,qtbase)))
     (arguments
      `(#:phases
-- 
2.7.4

bug#27251: [PATCH 26/27] gnu: knotifications: Add a todo comments.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (knotifications)[inputs]: Add comments.
---
 gnu/packages/kde-frameworks.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index c60bb85..daf7f43 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1579,6 +1579,9 @@ asynchronous jobs.")
        ("kwindowsystem" ,kwindowsystem)
        ("phonon" ,phonon)
        ("qtbase" ,qtbase)
+       ;; TODO: qtspeech (new in Qt 5.9)
+       ;; TODO: Think about adding dbusmenu-qt5 from
+       ;; https://launchpad.net/libdbusmenu-qt
        ("qtx11extras" ,qtx11extras)))
     (arguments
      `(#:phases
-- 
2.7.4

bug#27251: [PATCH 27/27] gnu: solid: Add a todo comment.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (solid)[inputs]: Add comment.
---
 gnu/packages/kde-frameworks.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index daf7f43..269c8eb 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1199,6 +1199,7 @@ which are used in DBus communication.")
     (inputs
      `(("qtbase" ,qtbase)
        ("udev" ,eudev)))
+    ;; TODO: Add runtime-only dependency MediaPlayerInfo
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Desktop hardware abstraction")
     (description "Solid is a device integration framework.  It provides a way of
-- 
2.7.4

bug#27251: [PATCH 17/27] gnu: gpgmepp: Superseded by gpgme.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> The C++-bindings are part of gpgme since version 1.7.

Can you move this comment...

> * gnu/packages/kde-frameworks.scm (gpgmepp)[properties]: New field.
> ---
>  gnu/packages/kde-frameworks.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 2535a38..323b125 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -205,7 +205,8 @@ Phonon-GStreamer is a backend based on the GStreamer multimedia library.")
>      (home-page "https://community.kde.org/Frameworks")
>      (synopsis "C++ bindings/wrapper for gpgme")
>      (description "C++ bindings/wrapper for gpgme.")
> -    (license license:lgpl2.1+)))
> +    (license license:lgpl2.1+)
> +    (properties `((superseded . ,gpgme)))))

...above properties here.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#27251: [PATCH 00/27] KDE Frameworks: Add inputs, fix some tests, cleanup.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> This patch series for kde-frameworks.scm
>
>  * adds (almost) all optional and recommended inputs
>  * adds comments for still missing optional or recommended inputs
>  * removes the requirement on xorg-server for tests where possible.
>     Some packages started a x.org server for testing, which can be
>     avoided by setting QT_QPA_PLATFORM=offscreen.
>  * re-anables some test-suites now passing
>  * retains the progress on makeing a test-suite pass (while keeping the
>    still-failing test-suite disabled)

Cool! I've read through the patches and they LGTM.

I'm not sure if the standalone "X/Y tests fail" comment updates are
necessary, but the functional changes look fine. Maybe we could squash
the other TODO updates? No strong opinion.

While somewhat useful, they're also quite "noisy".

Thanks for working on KDE! I'll give it a try on the HTPC soon :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#27251: [PATCH 00/27] KDE Frameworks: Add inputs, fix some tests, cleanup.

[Hartmut Goebel]

I merged all commits adding or changing comments only into a single commit.
pushed as  1e0ae3b352d4521aa2a88158ab49277cea7cd0bd