unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: 27251@debbugs.gnu.org
Subject: bug#27251: [PATCH 21/27] gnu: kwindowsystem: Fix some test-cases (test-suite still disabled).
Date: Mon,  5 Jun 2017 17:35:12 +0200	[thread overview]
Message-ID: <1496676918-6707-21-git-send-email-h.goebel@crazy-compilers.com> (raw)
In-Reply-To: <1496676918-6707-1-git-send-email-h.goebel@crazy-compilers.com>

Make five tests pass, three are still failing – thus the test-suite is still
disabled. This commit's aim is to retain the progress.

* gnu/packages/kde-frameworks.scm (kwindowsystem)[native-inputs]: Add dbus.
  [arguments]<#:test?>: Change comment. <#:phases>: Replace phase `check` by
  new one befind 'install'.
---
 gnu/packages/kde-frameworks.scm | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index abedcff..1d1c3f2 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1017,6 +1017,7 @@ configuration pages, message boxes, and password requests.")
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("pkg-config" ,pkg-config)
+       ("dbus" ,dbus) ; for the tests
        ("qttools" ,qttools)
        ("xorg-server" ,xorg-server))) ; for the tests
     (inputs
@@ -1025,7 +1026,31 @@ configuration pages, message boxes, and password requests.")
        ("qtx11extras" ,qtx11extras)
        ("xcb-utils-keysyms" ,xcb-util-keysyms)))
     (arguments
-     `(#:tests? #f)) ; FIXME: 8/10 tests fail.
+     `(#:tests? #f ; FIXME: 3/12 tests fail.
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'check)
+         (add-after 'install 'check
+           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+             ;; TODO: Simplify and use "common" phases when test-suite passes
+             (if tests?
+                 (begin
+                   (let ((out (assoc-ref outputs "out")))
+                     (setenv "QT_PLUGIN_PATH"
+                             (string-append out "/lib/plugins:"
+                                            (getenv "QT_PLUGIN_PATH"))))
+                   ;; The test suite requires a running X server, setting
+                   ;; QT_QPA_PLATFORM=offscreen does not suffice and even make
+                   ;; some tests fail.
+                   (system (string-append (assoc-ref inputs "xorg-server")
+                                          "/bin/Xvfb :1 -screen 0 640x480x24 &"))
+                   (setenv "DISPLAY" ":1")
+                   (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
+                   (setenv "DBUS_FATAL_WARNINGS" "0")
+                   (zero? (system* "dbus-launch" "ctest" ".")))
+                 (begin
+                   (format #t "test suite not run~%")
+                   #t)))))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "KDE access to the windowing system")
     (description "KWindowSystem provides information about and allows
-- 
2.7.4

  parent reply	other threads:[~2017-06-05 15:36 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 11:53 bug#27251: [PATCH 00/27] KDE Frameworks: Add inputs, fix some tests, cleanup Hartmut Goebel
2017-06-05 15:34 ` bug#27251: [PATCH 01/27] gnu: kguiaddons: Add more optional inputs Hartmut Goebel
2017-06-05 15:34   ` bug#27251: [PATCH 02/27] gnu: kguiaddons: Remove unused native input Hartmut Goebel
2017-06-05 15:34   ` bug#27251: [PATCH 03/27] gnu: kguiaddons: Add a todo comment Hartmut Goebel
2017-06-05 15:34   ` bug#27251: [PATCH 04/27] gnu: kitemmodels: Add more optional inputs Hartmut Goebel
2017-06-05 15:34   ` bug#27251: [PATCH 05/27] gnu: kcompletion: Remove unused native input Hartmut Goebel
2017-06-05 15:34   ` bug#27251: [PATCH 06/27] gnu: kde frameworks: Avoid requiring xorg-server for tests Hartmut Goebel
2017-06-05 15:34   ` bug#27251: [PATCH 07/27] gnu: kimageformats: Add more optional and recommended inputs Hartmut Goebel
2017-06-05 15:34   ` bug#27251: [PATCH 08/27] gnu: kio: " Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 09/27] gnu: kinit: Add more optional inputs Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 10/27] gnu: ktexteditor: " Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 11/27] gnu: ktexteditor: Add a todo comment Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 12/27] gnu: plasma-framework: Add more optional inputs Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 13/27] gnu: plasma-framework: Update comment (number of failed tests) Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 14/27] gnu: kpackage: Add more optional inputs Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 15/27] gnu: kpackage: Update comment (number of failed tests) Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 16/27] gnu: sonnet: Add optional input (spell-checker) Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 17/27] gnu: gpgmepp: Superseded by gpgme Hartmut Goebel
2017-06-06 19:58     ` Marius Bakke
2017-06-05 15:35   ` bug#27251: [PATCH 18/27] gnu: kwallet: Use gpgme instead of gpgmepp Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 19/27] gnu: kiconthemes: Re-enable tests Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 20/27] gnu: kwidgetsaddons: " Hartmut Goebel
2017-06-05 15:35   ` Hartmut Goebel [this message]
2017-06-05 15:35   ` bug#27251: [PATCH 22/27] gnu: kdeclarative: Update comment Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 23/27] gnu: kpty: Add a todo comment Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 24/27] gnu: phonon: " Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 25/27] gnu: ktextwidgets: " Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 26/27] gnu: knotifications: Add a todo comments Hartmut Goebel
2017-06-05 15:35   ` bug#27251: [PATCH 27/27] gnu: solid: Add a todo comment Hartmut Goebel
2017-06-06 20:27 ` bug#27251: [PATCH 00/27] KDE Frameworks: Add inputs, fix some tests, cleanup Marius Bakke
2017-06-08 17:17   ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496676918-6707-21-git-send-email-h.goebel@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=27251@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).