* [bug#37701] [PATCH] gnu: Add playerctl. @ 2019-10-11 12:52 David Wilson 2019-10-13 21:58 ` bug#37701: " Ludovic Courtès 0 siblings, 1 reply; 3+ messages in thread From: David Wilson @ 2019-10-11 12:52 UTC (permalink / raw) To: 37701 [-- Attachment #1: Type: text/plain, Size: 493 bytes --] Hi all! This patch adds the 'playerctl' command line utility for controlling media players that support MPRIS. As this is my first attempt at packaging software for Guix, please let me know if anything can be improved. I've run through most of the steps in the packaging checklist of the manual so I feel pretty confident that it's in good shape. Also, this is my first contribution to a GNU project (!!) so please advise if I need to follow any "new contributor" protocol. Thanks! David [-- Attachment #2: 0001-gnu-Add-playerctl.patch --] [-- Type: application/octet-stream, Size: 2277 bytes --] From 536c7d321ca310762940205358ce26a7141c8e9c Mon Sep 17 00:00:00 2001 From: David Wilson <david@daviwil.com> Date: Thu, 10 Oct 2019 22:06:43 -0700 Subject: [PATCH] gnu: Add playerctl. * gnu/packages/music.scm (playerctl): New variable. --- gnu/packages/music.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index ac4333168c..dcda71a43d 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -23,6 +23,7 @@ ;;; Copyright © 2019 Timotej Lazar <timotej.lazar@araneo.si> ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays@sdf.lonestar.org> ;;; Copyright © 2019 raingloom <raingloom@protonmail.com> +;;; Copyright © 2019 David Wilson <david@daviwil.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -4622,4 +4623,32 @@ easier to perform. Features include: @item Adjust tempo; Playback speed of loops can be adjusted on the fly. @end itemize\n") (license license:gpl2)))) + +(define-public playerctl + (package + (name "playerctl") + (version "2.0.2") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/altdesktop/playerctl.git") + (commit (string-append "v" version)))) + (sha256 + (base32 + "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz")))) + (build-system meson-build-system) + (arguments + `(#:configure-flags '("-Dintrospection=false" "-Dgtk-doc=false"))) + (inputs `(("python-pygobject" ,python-pygobject))) + (native-inputs + `(("glib:bin" ,glib "bin") + ("pkg-config" ,pkg-config))) + (synopsis "Controls MPRIS-supporting media player applications") + (description + "Playerctl is a command-line utility and library for controlling media +players that implement the MPRIS D-Bus Interface Specification. Playerctl +makes it easy to bind player actions, such as play and pause, to media keys. +You can also get metadata about the playing track such as the artist and title +for integration into status line generators or other command-line tools.") + (home-page "https://github.com/altdesktop/playerctl") + (license license:lgpl3))) -- 2.23.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#37701: [PATCH] gnu: Add playerctl. 2019-10-11 12:52 [bug#37701] [PATCH] gnu: Add playerctl David Wilson @ 2019-10-13 21:58 ` Ludovic Courtès 2019-10-13 22:11 ` [bug#37701] " David Wilson 0 siblings, 1 reply; 3+ messages in thread From: Ludovic Courtès @ 2019-10-13 21:58 UTC (permalink / raw) To: David Wilson; +Cc: 37701-done [-- Attachment #1: Type: text/plain, Size: 1094 bytes --] Hi David, "David Wilson" <david@daviwil.com> skribis: > This patch adds the 'playerctl' command line utility for controlling media players that support MPRIS. As this is my first attempt at packaging software for Guix, please let me know if anything can be improved. I've run through most of the steps in the packaging checklist of the manual so I feel pretty confident that it's in good shape. > > Also, this is my first contribution to a GNU project (!!) so please advise if I need to follow any "new contributor" protocol. Looks like you followed the protocol perfectly well! :-) > From 536c7d321ca310762940205358ce26a7141c8e9c Mon Sep 17 00:00:00 2001 > From: David Wilson <david@daviwil.com> > Date: Thu, 10 Oct 2019 22:06:43 -0700 > Subject: [PATCH] gnu: Add playerctl. > > * gnu/packages/music.scm (playerctl): New variable. Applied with the minor changes below: the ‘file-name’ issue was reported by ‘guix lint’, and the license is LGPLv3-or-later because source file headers carry the “or any later version” wording. Thank you! Ludo’. [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: Type: text/x-patch, Size: 1399 bytes --] diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index dcda71a43d..a051caca2b 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4633,6 +4633,7 @@ easier to perform. Features include: (uri (git-reference (url "https://github.com/altdesktop/playerctl.git") (commit (string-append "v" version)))) + (file-name (git-file-name name version)) (sha256 (base32 "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz")))) @@ -4643,7 +4644,7 @@ easier to perform. Features include: (native-inputs `(("glib:bin" ,glib "bin") ("pkg-config" ,pkg-config))) - (synopsis "Controls MPRIS-supporting media player applications") + (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Playerctl @@ -4651,4 +4652,4 @@ makes it easy to bind player actions, such as play and pause, to media keys. You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl") - (license license:lgpl3))) + (license license:lgpl3+))) ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#37701] [PATCH] gnu: Add playerctl. 2019-10-13 21:58 ` bug#37701: " Ludovic Courtès @ 2019-10-13 22:11 ` David Wilson 0 siblings, 0 replies; 3+ messages in thread From: David Wilson @ 2019-10-13 22:11 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 37701-done [-- Attachment #1.1.1: Type: text/plain, Size: 1324 bytes --] Thanks so much Ludo! I wasn't sure about whether the license included future versions, will keep an eye on the file headers in the future. David On Sun, Oct 13, 2019 at 2:59 PM -0700, "Ludovic Courtès" <ludo@gnu.org> wrote: Hi David, "David Wilson" skribis: > This patch adds the 'playerctl' command line utility for controlling media players that support MPRIS. As this is my first attempt at packaging software for Guix, please let me know if anything can be improved. I've run through most of the steps in the packaging checklist of the manual so I feel pretty confident that it's in good shape. > > Also, this is my first contribution to a GNU project (!!) so please advise if I need to follow any "new contributor" protocol. Looks like you followed the protocol perfectly well! :-) > From 536c7d321ca310762940205358ce26a7141c8e9c Mon Sep 17 00:00:00 2001 > From: David Wilson > Date: Thu, 10 Oct 2019 22:06:43 -0700 > Subject: [PATCH] gnu: Add playerctl. > > * gnu/packages/music.scm (playerctl): New variable. Applied with the minor changes below: the ‘file-name’ issue was reported by ‘guix lint’, and the license is LGPLv3-or-later because source file headers carry the “or any later version” wording. Thank you! Ludo’. [-- Attachment #1.1.2: Type: text/html, Size: 2214 bytes --] [-- Attachment #1.2: 2_TEXT_X-PATCH --] [-- Type: TEXT/X-PATCH, Size: 1399 bytes --] diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index dcda71a43d..a051caca2b 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4633,6 +4633,7 @@ easier to perform. Features include: (uri (git-reference (url "https://github.com/altdesktop/playerctl.git") (commit (string-append "v" version)))) + (file-name (git-file-name name version)) (sha256 (base32 "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz")))) @@ -4643,7 +4644,7 @@ easier to perform. Features include: (native-inputs `(("glib:bin" ,glib "bin") ("pkg-config" ,pkg-config))) - (synopsis "Controls MPRIS-supporting media player applications") + (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Playerctl @@ -4651,4 +4652,4 @@ makes it easy to bind player actions, such as play and pause, to media keys. You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl") - (license license:lgpl3))) + (license license:lgpl3+))) [-- Attachment #2: 2_TEXT_X-PATCH --] [-- Type: TEXT/X-PATCH, Size: 1399 bytes --] diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index dcda71a43d..a051caca2b 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4633,6 +4633,7 @@ easier to perform. Features include: (uri (git-reference (url "https://github.com/altdesktop/playerctl.git") (commit (string-append "v" version)))) + (file-name (git-file-name name version)) (sha256 (base32 "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz")))) @@ -4643,7 +4644,7 @@ easier to perform. Features include: (native-inputs `(("glib:bin" ,glib "bin") ("pkg-config" ,pkg-config))) - (synopsis "Controls MPRIS-supporting media player applications") + (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Playerctl @@ -4651,4 +4652,4 @@ makes it easy to bind player actions, such as play and pause, to media keys. You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl") - (license license:lgpl3))) + (license license:lgpl3+))) ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-14 5:38 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-11 12:52 [bug#37701] [PATCH] gnu: Add playerctl David Wilson 2019-10-13 21:58 ` bug#37701: " Ludovic Courtès 2019-10-13 22:11 ` [bug#37701] " David Wilson
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).