From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:60993) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJt3V-0005TX-KV for guix-patches@gnu.org; Mon, 14 Oct 2019 01:38:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJt3U-0007MK-1d for guix-patches@gnu.org; Mon, 14 Oct 2019 01:38:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56954) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJt3T-0007M5-KL for guix-patches@gnu.org; Mon, 14 Oct 2019 01:38:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iJt3T-0001xb-HU for guix-patches@gnu.org; Mon, 14 Oct 2019 01:38:03 -0400 Subject: [bug#37701] [PATCH] gnu: Add playerctl. Resent-Message-ID: Date: Sun, 13 Oct 2019 22:11:59 +0000 (UTC) From: David Wilson Message-ID: <146CCE75D21B3446.d994f6e3-509c-4a25-8cab-f9a20bc806d6@mail.outlook.com> In-Reply-To: <875zks8fz6.fsf@gnu.org> References: <5e3cd1fc-bb34-48cc-9f28-24bcec0333c9@www.fastmail.com> <875zks8fz6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_9193_1434239559.1571004719323" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 37701-done@debbugs.gnu.org ------=_Part_9193_1434239559.1571004719323 Content-Type: multipart/related; boundary="----=_Part_9191_825516628.1571004719322" ------=_Part_9191_825516628.1571004719322 Content-Type: multipart/alternative; boundary="----=_Part_9192_2089077627.1571004719322" ------=_Part_9192_2089077627.1571004719322 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks so much Ludo! I wasn't sure about whether the license included futur= e versions, will keep an eye on the file headers in the future.=C2=A0 David On Sun, Oct 13, 2019 at 2:59 PM -0700, "Ludovic Court=C3=A8s" wrote: Hi David, "David Wilson" skribis: > This patch adds the 'playerctl' command line utility for controlling medi= a players that support MPRIS. As this is my first attempt at packaging sof= tware for Guix, please let me know if anything can be improved. I've run t= hrough most of the steps in the packaging checklist of the manual so I feel= pretty confident that it's in good shape. > > Also, this is my first contribution to a GNU project (!!) so please advis= e if I need to follow any "new contributor" protocol. Looks like you followed the protocol perfectly well! :-) > From 536c7d321ca310762940205358ce26a7141c8e9c Mon Sep 17 00:00:00 2001 > From: David Wilson=20 > Date: Thu, 10 Oct 2019 22:06:43 -0700 > Subject: [PATCH] gnu: Add playerctl. > > * gnu/packages/music.scm (playerctl): New variable. Applied with the minor changes below: the =E2=80=98file-name=E2=80=99 issue= was reported by =E2=80=98guix lint=E2=80=99, and the license is LGPLv3-or-later because = source file headers carry the =E2=80=9Cor any later version=E2=80=9D wording. Thank you! Ludo=E2=80=99. ------=_Part_9192_2089077627.1571004719322 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Thanks so much Ludo! I wasn't sure about whether the lic= ense included future versions, will keep an eye on the file headers in the = future.

David

On Sun, Oct 13, 2019 at 2:59 PM -0700, "Ludovic = Court=C3=A8s" <ludo@gnu.org> wrote:

Hi David,

"David Wilson"  skribis:

> This patch adds the 'playerctl' command line utility for controlling m=
edia players that support MPRIS.  As this is my first attempt at packaging =
software for Guix, please let me know if anything can be improved.  I've ru=
n through most of the steps in the packaging checklist of the manual so I f=
eel pretty confident that it's in good shape.
>
> Also, this is my first contribution to a GNU project (!!) so please ad=
vise if I need to follow any "new contributor" protocol.

Looks like you followed the protocol perfectly well!  :-)

> From 536c7d321ca310762940205358ce26a7141c8e9c Mon Sep 17 00:00:00 2001
> From: David Wilson 
> Date: Thu, 10 Oct 2019 22:06:43 -0700
> Subject: [PATCH] gnu: Add playerctl.
>
> * gnu/packages/music.scm (playerctl): New variable.

Applied with the minor changes below: the =E2=80=98file-name=E2=80=99 issue=
 was reported
by =E2=80=98guix lint=E2=80=99, and the license is LGPLv3-or-later because =
source file
headers carry the =E2=80=9Cor any later version=E2=80=9D wording.

Thank you!

Ludo=E2=80=99.

------=_Part_9192_2089077627.1571004719322-- ------=_Part_9191_825516628.1571004719322 Content-Type: TEXT/X-PATCH; charset=us-ascii; name=2_TEXT_X-PATCH Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename=2_TEXT_X-PATCH diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index dcda71a43d..a051caca2b 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4633,6 +4633,7 @@ easier to perform. Features include: (uri (git-reference (url "https://github.com/altdesktop/playerctl.git") (commit (string-append "v" version)))) + (file-name (git-file-name name version)) (sha256 (base32 "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz")))) @@ -4643,7 +4644,7 @@ easier to perform. Features include: (native-inputs `(("glib:bin" ,glib "bin") ("pkg-config" ,pkg-config))) - (synopsis "Controls MPRIS-supporting media player applications") + (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Playerctl @@ -4651,4 +4652,4 @@ makes it easy to bind player actions, such as play and pause, to media keys. You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl") - (license license:lgpl3))) + (license license:lgpl3+))) ------=_Part_9191_825516628.1571004719322-- ------=_Part_9193_1434239559.1571004719323 Content-Type: TEXT/X-PATCH; charset=us-ascii; name=2_TEXT_X-PATCH Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=2_TEXT_X-PATCH diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index dcda71a43d..a051caca2b 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -4633,6 +4633,7 @@ easier to perform. Features include: (uri (git-reference (url "https://github.com/altdesktop/playerctl.git") (commit (string-append "v" version)))) + (file-name (git-file-name name version)) (sha256 (base32 "1f3njnpd52djx3dmhh9a8p5a67f0jmr1gbk98icflr2q91149gjz")))) @@ -4643,7 +4644,7 @@ easier to perform. Features include: (native-inputs `(("glib:bin" ,glib "bin") ("pkg-config" ,pkg-config))) - (synopsis "Controls MPRIS-supporting media player applications") + (synopsis "Control MPRIS-supporting media player applications") (description "Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Playerctl @@ -4651,4 +4652,4 @@ makes it easy to bind player actions, such as play and pause, to media keys. You can also get metadata about the playing track such as the artist and title for integration into status line generators or other command-line tools.") (home-page "https://github.com/altdesktop/playerctl") - (license license:lgpl3))) + (license license:lgpl3+))) ------=_Part_9193_1434239559.1571004719323--