From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add eXpress.
Date: Tue, 21 Apr 2015 17:59:10 +0200 [thread overview]
Message-ID: <idjd22xv5f5.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <87383tij5v.fsf@gnu.org>
Ludovic Courtès writes:
>> + (alist-cons-after
>> + 'unpack 'use-shared-boost-libs-and-set-bamtools-paths
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (substitute* "CMakeLists.txt"
>> + (("set\\(Boost_USE_STATIC_LIBS ON\\)")
>> + "set(Boost_USE_STATIC_LIBS OFF)")
>
> I think the same effect can be achieved by passing
> -DBoost_USE_STATIC_LIBS=OFF to cmake (i.e., as #:configure-flags.)
> It might be slightly more elegant, but no big deal.
Unfortunately, I haven't been able to get this to work with
#:configure-flags nor with #:make-flags. I just pushed both commits.q
Thank you for the review!
~~ Ricardo
prev parent reply other threads:[~2015-04-21 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 13:19 [PATCH] gnu: Add eXpress Ricardo Wurmus
2015-04-21 15:40 ` Ludovic Courtès
2015-04-21 15:59 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjd22xv5f5.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).