From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] gnu: Add eXpress.
Date: Tue, 21 Apr 2015 17:59:10 +0200
Message-ID: <idjd22xv5f5.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjbnioxlb6.fsf@bimsb-sys02.mdc-berlin.net>
	<87383tij5v.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33978)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Ykaa3-0006Ix-NF
	for guix-devel@gnu.org; Tue, 21 Apr 2015 11:59:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1Ykaa0-0003GN-E8
	for guix-devel@gnu.org; Tue, 21 Apr 2015 11:59:23 -0400
In-Reply-To: <87383tij5v.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>


Ludovic Court=C3=A8s writes:

>> +       (alist-cons-after
>> +        'unpack 'use-shared-boost-libs-and-set-bamtools-paths
>> +        (lambda* (#:key inputs #:allow-other-keys)
>> +          (substitute* "CMakeLists.txt"
>> +            (("set\\(Boost_USE_STATIC_LIBS ON\\)")
>> +             "set(Boost_USE_STATIC_LIBS OFF)")
>
> I think the same effect can be achieved by passing
> -DBoost_USE_STATIC_LIBS=3DOFF to cmake (i.e., as #:configure-flags.)
> It might be slightly more elegant, but no big deal.

Unfortunately, I haven't been able to get this to work with
#:configure-flags nor with #:make-flags.  I just pushed both commits.q

Thank you for the review!

~~ Ricardo