From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add eXpress.
Date: Tue, 21 Apr 2015 17:40:44 +0200 [thread overview]
Message-ID: <87383tij5v.fsf@gnu.org> (raw)
In-Reply-To: <idjbnioxlb6.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Thu, 16 Apr 2015 15:19:25 +0200")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> From 16e9535b2dad21cd585b6da94296f94164103de0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 16 Apr 2015 15:16:57 +0200
> Subject: [PATCH 1/2] gnu: Add bamtools.
>
> * gnu/packages/bioinformatics.scm (bamtools): New variable.
OK.
> From c65294547718078189bc920be8e5b07d57470060 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 16 Apr 2015 15:18:10 +0200
> Subject: [PATCH 2/2] gnu: Add eXpress.
>
> * gnu/packages/bioinformatics.scm (express): New variable.
[...]
> + (alist-cons-after
> + 'unpack 'use-shared-boost-libs-and-set-bamtools-paths
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "CMakeLists.txt"
> + (("set\\(Boost_USE_STATIC_LIBS ON\\)")
> + "set(Boost_USE_STATIC_LIBS OFF)")
I think the same effect can be achieved by passing
-DBoost_USE_STATIC_LIBS=OFF to cmake (i.e., as #:configure-flags.)
It might be slightly more elegant, but no big deal.
OK!
Ludo’.
next prev parent reply other threads:[~2015-04-21 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 13:19 [PATCH] gnu: Add eXpress Ricardo Wurmus
2015-04-21 15:40 ` Ludovic Courtès [this message]
2015-04-21 15:59 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87383tij5v.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).