[PATCH] Add optional dependencies to ipython.

[PATCH] Add optional dependencies to ipython.

[Ricardo Wurmus]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-python-ipython-Add-optional-dependencies.patch --]
[-- Type: text/x-patch, Size: 1392 bytes --]

From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Thu, 21 May 2015 15:24:11 +0200
Subject: [PATCH] gnu: python-ipython: Add optional dependencies.

* gnu/packages/python.scm (python-ipython)[inputs]: Add optional dependencies
  "python-tornado" and "python-pyzmq".
---
 gnu/packages/python.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5e4217a..9548d33 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3016,13 +3016,15 @@ Python language binding specification.")
        (base32 "1764gi5m3ff481rjk336cw6i2h4zlc0nxam9rc5m8m7yl9m4d61y"))))
     (build-system python-build-system)
     (outputs '("out" "doc"))
-    ;; FIXME: add optional dependencies when available: pyzmq, tornado, ...
+    ;; FIXME: add optional dependencies when available: pexpect
     (inputs
      `(("readline" ,readline)
        ("python-matplotlib" ,python-matplotlib)
        ("python-numpy" ,python-numpy-bootstrap)
        ("python-numpydoc" ,python-numpydoc)
-       ("python-nose" ,python-nose)))
+       ("python-nose" ,python-nose)
+       ("python-tornado" ,python-tornado)
+       ("python-pyzmq" ,python-pyzmq)))
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("python-sphinx" ,python-sphinx)
-- 
2.1.0

Re: [PATCH] Add optional dependencies to ipython.

[Ludovic Courtès]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 21 May 2015 15:24:11 +0200
> Subject: [PATCH] gnu: python-ipython: Add optional dependencies.
>
> * gnu/packages/python.scm (python-ipython)[inputs]: Add optional dependencies
>   "python-tornado" and "python-pyzmq".

LGTM.  One question though: how much does it add to the ipython’s
closure size, and is it something that many ipython users would have
little use for?

IOW, the popularity/extra-space ratio should be greater than one.  :-)

Ludo’.

Re: [PATCH] Add optional dependencies to ipython.

[Ricardo Wurmus]

>> From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Thu, 21 May 2015 15:24:11 +0200
>> Subject: [PATCH] gnu: python-ipython: Add optional dependencies.
>>
>> * gnu/packages/python.scm (python-ipython)[inputs]: Add optional dependencies
>>   "python-tornado" and "python-pyzmq".
>
> LGTM.  One question though: how much does it add to the ipython’s
> closure size, and is it something that many ipython users would have
> little use for?
>
> IOW, the popularity/extra-space ratio should be greater than one.  :-)

Before the patch:

  du -ms $(guix gc -R \
    /gnu/store/frjwvppazzjvp7pzwfawa9nrq1nx135q-python-ipython-2.3.1) | \
    cut -f1 | paste -s -d+ | bc

  ==> 683 MB

After the patch:

  du -ms $(guix gc -R \
    /gnu/store/bqpmsh45fzmjynczcwx6zvycinf7c91r-python-ipython-2.3.1) | \
    cut -f1 | paste -s -d+ | bc

  ==> 765 MB

I don't know if support for python-tornado and python-pyzmq in
python-ipython is worth an additional 82 MB.

It was only after I packaged python-tornado and python-pyzmq for other
purposes that I noticed that python-ipython takes it as an optional
input, so I added it.  (Personally, I don't need it because I'm not an
IPython user.)

~~ Ricardo

Re: [PATCH] Add optional dependencies to ipython.

[Ludovic Courtès]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

>>> From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
>>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>>> Date: Thu, 21 May 2015 15:24:11 +0200
>>> Subject: [PATCH] gnu: python-ipython: Add optional dependencies.
>>>
>>> * gnu/packages/python.scm (python-ipython)[inputs]: Add optional dependencies
>>>   "python-tornado" and "python-pyzmq".
>>
>> LGTM.  One question though: how much does it add to the ipython’s
>> closure size, and is it something that many ipython users would have
>> little use for?
>>
>> IOW, the popularity/extra-space ratio should be greater than one.  :-)

[...]

> I don't know if support for python-tornado and python-pyzmq in
> python-ipython is worth an additional 82 MB.

My guess is that no, it’s not worth it.  So let’s leave it this way,
maybe adding a comment to the future reader who wonders why these two
are missing.

Now, 683 MiB is already a lot, and it would be interesting to analyze
why it’s so big.

Thanks!

Ludo’.

[PATCH] Add optional dependencies to ipython.

[Federico Beffa]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 21 May 2015 15:24:11 +0200
> Subject: [PATCH] gnu: python-ipython: Add optional dependencies.
>
> * gnu/packages/python.scm (python-ipython)[inputs]: Add optional dependencies
>   "python-tornado" and "python-pyzmq".
> ---
>  gnu/packages/python.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 5e4217a..9548d33 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3016,13 +3016,15 @@ Python language binding specification.")
>         (base32 "1764gi5m3ff481rjk336cw6i2h4zlc0nxam9rc5m8m7yl9m4d61y"))))
>      (build-system python-build-system)
>      (outputs '("out" "doc"))
> -    ;; FIXME: add optional dependencies when available: pyzmq, tornado, ...
> +    ;; FIXME: add optional dependencies when available: pexpect
>      (inputs
>       `(("readline" ,readline)
>         ("python-matplotlib" ,python-matplotlib)
>         ("python-numpy" ,python-numpy-bootstrap)
>         ("python-numpydoc" ,python-numpydoc)
> -       ("python-nose" ,python-nose)))
> +       ("python-nose" ,python-nose)
> +       ("python-tornado" ,python-tornado)
> +       ("python-pyzmq" ,python-pyzmq)))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("python-sphinx" ,python-sphinx)

I would welcome such additions because Emacs' org-mode doesn't work
well with ipython and a recent improvement on that requires these
additions.

https://github.com/gregsexton/ob-ipython

Regards,
Fede