From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Add optional dependencies to ipython.
Date: Wed, 27 May 2015 10:20:33 +0200
Message-ID: <idjoal6h1ny.fsf@bimsb-sys02.mdc-berlin.net>
References: <idjegmahxka.fsf@bimsb-sys02.mdc-berlin.net>
	<878uch1z47.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58821)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YxWZz-00078B-0D
	for guix-devel@gnu.org; Wed, 27 May 2015 04:20:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1YxWZt-0006Q7-MB
	for guix-devel@gnu.org; Wed, 27 May 2015 04:20:46 -0400
In-Reply-To: <878uch1z47.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>


>> From 9243823abad3943bd3f4ebe4f6d18cc53c2143e0 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> Date: Thu, 21 May 2015 15:24:11 +0200
>> Subject: [PATCH] gnu: python-ipython: Add optional dependencies.
>>
>> * gnu/packages/python.scm (python-ipython)[inputs]: Add optional depen=
dencies
>>   "python-tornado" and "python-pyzmq".
>
> LGTM.  One question though: how much does it add to the ipython=E2=80=99=
s
> closure size, and is it something that many ipython users would have
> little use for?
>
> IOW, the popularity/extra-space ratio should be greater than one.  :-)

Before the patch:

  du -ms $(guix gc -R \
    /gnu/store/frjwvppazzjvp7pzwfawa9nrq1nx135q-python-ipython-2.3.1) | \
    cut -f1 | paste -s -d+ | bc

  =3D=3D> 683 MB

After the patch:

  du -ms $(guix gc -R \
    /gnu/store/bqpmsh45fzmjynczcwx6zvycinf7c91r-python-ipython-2.3.1) | \
    cut -f1 | paste -s -d+ | bc

  =3D=3D> 765 MB

I don't know if support for python-tornado and python-pyzmq in
python-ipython is worth an additional 82 MB.

It was only after I packaged python-tornado and python-pyzmq for other
purposes that I noticed that python-ipython takes it as an optional
input, so I added it.  (Personally, I don't need it because I'm not an
IPython user.)

~~ Ricardo