From: "Thompson, David" <dthompson2@worcester.edu>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: pre-release [PATCH] git-service
Date: Fri, 8 Jul 2016 14:24:12 -0400 [thread overview]
Message-ID: <CAJ=RwfaBmbx9u-9_bMVH9WS2SXbV-W6YzwTbiZFpMeciz_9FjQ@mail.gmail.com> (raw)
In-Reply-To: <87zipsgm8g.fsf@we.make.ritual.n0.is>
On Fri, Jul 8, 2016 at 11:53 AM, ng0 <ng0@we.make.ritual.n0.is> wrote:
> I need some feedback on the git-service.
> The inserted patch gives me this output:
>
>
> +(define-record-type* <git-configuration>
> + git-configuration make-git-configuration
> + git-configuration?
> + (git git-configuration-git ; <package>
> + (default git))
> + (base-path git-configuration-base-path) ; string
> + (port git-configuration-port)) ; string
So, this is a record type...
> +
> +(define git-shepherd-service
> + (match-lambda
> + (($ <git-configuration> git base-path port)
> + (let ((conf (string-append
> + "--base-path="base-path
> + "--port="(number->string port))))
> + (list (shepherd-service
> + (provision '(git))
> + (requirement '(networking loopback syslogd))
> + (documentation "Run the git-daemon server for git repositories")
> + (start #~(make-forkexec-constructor
> + (list (string-append #$git "/bin/git")
> + "daemon" "--syslog" "--informative-errors"
> + #$conf)))
...and you (ungexp conf), where conf is an instance of that record
type, into what is supposed to be a list of strings that form command
line arguments for git. See the issue?
> + (stop #~(make-kill-destructor))))))))
- Dave
next prev parent reply other threads:[~2016-07-08 18:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 15:53 pre-release [PATCH] git-service ng0
2016-07-08 18:24 ` Thompson, David [this message]
2016-07-08 20:41 ` Ricardo Wurmus
2016-07-09 1:08 ` ng0
2016-07-13 10:23 ` ng0
2016-07-13 16:37 ` pre-release [PATCH] git-service [v2] ng0
2016-07-14 9:07 ` ng0
2016-08-11 15:55 ` ng0
2016-08-19 9:02 ` ng0
2016-08-22 8:03 ` Alex Kost
2016-08-25 9:55 ` ng0
2016-08-26 4:50 ` Alex Kost
2016-08-27 15:39 ` ng0
2016-08-27 20:09 ` Alex Kost
2016-08-27 20:44 ` ng0
2016-08-28 0:04 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfaBmbx9u-9_bMVH9WS2SXbV-W6YzwTbiZFpMeciz_9FjQ@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).