From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Thompson, David" <dthompson2@worcester.edu>
Subject: Re: pre-release [PATCH] git-service
Date: Fri, 8 Jul 2016 14:24:12 -0400
Message-ID: <CAJ=RwfaBmbx9u-9_bMVH9WS2SXbV-W6YzwTbiZFpMeciz_9FjQ@mail.gmail.com>
References: <87zipsgm8g.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52462)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1bLaRn-0001OA-HT
	for guix-devel@gnu.org; Fri, 08 Jul 2016 14:24:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1bLaRi-0002xi-N4
	for guix-devel@gnu.org; Fri, 08 Jul 2016 14:24:18 -0400
Received: from mail-vk0-x231.google.com ([2607:f8b0:400c:c05::231]:34646)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1bLaRi-0002xJ-Ht
	for guix-devel@gnu.org; Fri, 08 Jul 2016 14:24:14 -0400
Received: by mail-vk0-x231.google.com with SMTP id d67so65159754vkh.1
	for <guix-devel@gnu.org>; Fri, 08 Jul 2016 11:24:13 -0700 (PDT)
In-Reply-To: <87zipsgm8g.fsf@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel <guix-devel@gnu.org>

On Fri, Jul 8, 2016 at 11:53 AM, ng0 <ng0@we.make.ritual.n0.is> wrote:
> I need some feedback on the git-service.
> The inserted patch gives me this output:
>
>
> +(define-record-type* <git-configuration>
> +  git-configuration make-git-configuration
> +  git-configuration?
> +  (git       git-configuration-git ; <package>
> +             (default git))
> +  (base-path git-configuration-base-path) ; string
> +  (port      git-configuration-port)) ; string

So, this is a record type...

> +
> +(define git-shepherd-service
> +  (match-lambda
> +    (($ <git-configuration> git base-path port)
> +     (let ((conf (string-append
> +                  "--base-path="base-path
> +                  "--port="(number->string port))))
> +       (list (shepherd-service
> +              (provision '(git))
> +              (requirement '(networking loopback syslogd))
> +              (documentation "Run the git-daemon server for git repositories")
> +              (start #~(make-forkexec-constructor
> +                        (list (string-append #$git "/bin/git")
> +                              "daemon" "--syslog" "--informative-errors"
> +                              #$conf)))

...and you (ungexp conf), where conf is an instance of that record
type, into what is supposed to be a list of strings that form command
line arguments for git.  See the issue?

> +              (stop #~(make-kill-destructor))))))))

- Dave