From: ng0 <ng0@we.make.ritual.n0.is>
To: guix-devel <guix-devel@gnu.org>
Subject: Re: pre-release [PATCH] git-service
Date: Sat, 09 Jul 2016 01:08:38 +0000 [thread overview]
Message-ID: <87r3b3lisp.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <87r3b33ls5.fsf@elephly.net> (Ricardo Wurmus's message of "Fri, 08 Jul 2016 22:41:30 +0200")
Ricardo Wurmus <rekado@elephly.net> writes:
> Thompson, David <dthompson2@worcester.edu> writes:
>
>> On Fri, Jul 8, 2016 at 11:53 AM, ng0 <ng0@we.make.ritual.n0.is> wrote:
>>> I need some feedback on the git-service.
>>> The inserted patch gives me this output:
>>>
>>>
>>> +(define-record-type* <git-configuration>
>>> + git-configuration make-git-configuration
>>> + git-configuration?
>>> + (git git-configuration-git ; <package>
>>> + (default git))
>>> + (base-path git-configuration-base-path) ; string
>>> + (port git-configuration-port)) ; string
>>
>> So, this is a record type...
>>
>>> +
>>> +(define git-shepherd-service
>>> + (match-lambda
>>> + (($ <git-configuration> git base-path port)
>>> + (let ((conf (string-append
>>> + "--base-path="base-path
>>> + "--port="(number->string port))))
>>> + (list (shepherd-service
>>> + (provision '(git))
>>> + (requirement '(networking loopback syslogd))
>>> + (documentation "Run the git-daemon server for git repositories")
>>> + (start #~(make-forkexec-constructor
>>> + (list (string-append #$git "/bin/git")
>>> + "daemon" "--syslog" "--informative-errors"
>>> + #$conf)))
>>
>> ...and you (ungexp conf), where conf is an instance of that record
>> type, into what is supposed to be a list of strings that form command
>> line arguments for git. See the issue?
>
> I might be misreading this, but “conf” here is literally the string
>
> “--base-path=something--port=1234”
>
> when “base-path” is the string “something” and “port” is the number
> “1234”.
>
> The let binding for “conf” is incorrect.
>
> First, you say earlier that “port” is a string:
>
>> + (port git-configuration-port)) ; string
>
> but then you pass it to “number->string”, so it’s actually expected to
> be a number.
>
> Second, the argument to “make-forkexec-constructor” is supposed to be a
> list of strings, each representing one argument. So defining “conf” as
> a concatenation is not okay. You don’t need a let-binding for “conf” at
> all. Just use “base-path” and “port” directly. (I haven’t tested
> this.)
>
> (list (string-append #$git "/bin/git")
> "daemon" "--syslog" "--informative-errors"
> (string-append "--base-path=" $#base-path)
> (string-append "--port=" $#port))
>
> But the error you get stems from passing a value of
> “<git-configuration>” to something that expects a package. I don’t see
> where this happens. Since I cannot see “~/testvm.scm” I cannot tell you
> anything more.
>
> ~~ Ricardo
>
I just came back, I'll look at everything else tomorrow. Thanks
for the replies so far!
This is the testvm.scm:
(use-modules (gnu) (gnu system nss))
(use-service-modules desktop networking ssh version-control dbus avahi xorg)
(use-package-modules certs)
(use-package-modules tor emacs xorg version-control avahi xorg ssh)
(operating-system
(host-name "testvm")
(timezone "UTC")
(locale "en_US.UTF-8")
(bootloader (grub-configuration (device "/dev/sda")))
(file-systems
(list (file-system
(mount-point "/")
(device "dummy")
(type "dummy"))
%binary-format-file-system))
(users (list (user-account
(name "ng0")
(comment "")
(group "users")
(supplementary-groups '("wheel" "netdev"
"audio" "video"))
(home-directory "/home/ng0")
(password ""))))
(services (cons* (slim-service #:auto-login? #t
#:default-user "ng0")
(console-keymap-service "de-latin1")
(static-networking-service "eth0" "10.0.2.10"
#:name-servers '("10.0.2.3")
#:gateway "10.0.2.2")
;;(avahi-service)
;;(dbus-service (list avahi))
(git-service)
%base-services))
(pam-services
(base-pam-services #:allow-empty-passwords? #t))
(packages (cons* emacs openssh git xterm
avahi findutils grep which xmodmap
%base-packages)))
--
♥Ⓐ ng0
For non-prism friendly talk find me on http://www.psyced.org
SecuShare – http://secushare.org
next prev parent reply other threads:[~2016-07-09 1:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 15:53 pre-release [PATCH] git-service ng0
2016-07-08 18:24 ` Thompson, David
2016-07-08 20:41 ` Ricardo Wurmus
2016-07-09 1:08 ` ng0 [this message]
2016-07-13 10:23 ` ng0
2016-07-13 16:37 ` pre-release [PATCH] git-service [v2] ng0
2016-07-14 9:07 ` ng0
2016-08-11 15:55 ` ng0
2016-08-19 9:02 ` ng0
2016-08-22 8:03 ` Alex Kost
2016-08-25 9:55 ` ng0
2016-08-26 4:50 ` Alex Kost
2016-08-27 15:39 ` ng0
2016-08-27 20:09 ` Alex Kost
2016-08-27 20:44 ` ng0
2016-08-28 0:04 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3b3lisp.fsf@we.make.ritual.n0.is \
--to=ng0@we.make.ritual.n0.is \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).