* [PATCH] gnu: Add ruby-gherkin3
@ 2015-09-15 14:48 pjotr.public12
2015-09-15 14:55 ` Thompson, David
2015-09-15 18:37 ` Thompson, David
0 siblings, 2 replies; 3+ messages in thread
From: pjotr.public12 @ 2015-09-15 14:48 UTC (permalink / raw)
To: guix-devel
* gnu/packages/ruby.scm (ruby-gherkin3): New variable.
---
gnu/packages/ruby.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index ee0acc8..4756cd4 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1124,3 +1124,28 @@ it unifies the API for web servers, web frameworks, and software in between
into a single method call.")
(home-page "http://rack.github.io/")
(license license:expat)))
+
+(define-public ruby-gherkin3
+ (package
+ (name "ruby-gherkin3")
+ (version "3.1.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "gherkin3" version))
+ (sha256
+ (base32
+ "0xsyxhqa1gwcxzvsdy4didaiq5vam8ma3fbwbw2w60via4k6r1z9"))))
+ (build-system ruby-build-system)
+ (native-inputs
+ `(("bundler" ,bundler)
+ ("ruby-rspec" ,ruby-rspec)))
+ (arguments
+ '(#:tests? #f)) ; needs simplecov, among others
+ (synopsis "Gherkin parser")
+ (description "Gherkin 3 is a parser and compiler for the Gherkin
+language. It is intended to replace Gherkin 2 and be used by all
+Cucumber implementations to parse .feature files.")
+ (home-page
+ "https://github.com/cucumber/gherkin3")
+ (license expat)))
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gnu: Add ruby-gherkin3
2015-09-15 14:48 [PATCH] gnu: Add ruby-gherkin3 pjotr.public12
@ 2015-09-15 14:55 ` Thompson, David
2015-09-15 18:37 ` Thompson, David
1 sibling, 0 replies; 3+ messages in thread
From: Thompson, David @ 2015-09-15 14:55 UTC (permalink / raw)
To: Pjotr Prins; +Cc: guix-devel
On Tue, Sep 15, 2015 at 10:48 AM, <pjotr.public12@thebird.nl> wrote:
> * gnu/packages/ruby.scm (ruby-gherkin3): New variable.
Looks good to me. Just minor comments below.
> ---
> gnu/packages/ruby.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index ee0acc8..4756cd4 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -1124,3 +1124,28 @@ it unifies the API for web servers, web frameworks, and software in between
> into a single method call.")
> (home-page "http://rack.github.io/")
> (license license:expat)))
> +
> +(define-public ruby-gherkin3
> + (package
> + (name "ruby-gherkin3")
> + (version "3.1.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "gherkin3" version))
> + (sha256
> + (base32
> + "0xsyxhqa1gwcxzvsdy4didaiq5vam8ma3fbwbw2w60via4k6r1z9"))))
> + (build-system ruby-build-system)
> + (native-inputs
> + `(("bundler" ,bundler)
> + ("ruby-rspec" ,ruby-rspec)))
Let's remove rspec since we aren't running tests
> + (arguments
> + '(#:tests? #f)) ; needs simplecov, among others
> + (synopsis "Gherkin parser")
Maybe "Gherkin parser for Ruby"
> + (description "Gherkin 3 is a parser and compiler for the Gherkin
> +language. It is intended to replace Gherkin 2 and be used by all
> +Cucumber implementations to parse .feature files.")
> + (home-page
> + "https://github.com/cucumber/gherkin3")
Move to same line as 'home-page'.
> + (license expat)))
Needs prefix: license:expat
> --
> 2.4.3
>
>
- Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gnu: Add ruby-gherkin3
2015-09-15 14:48 [PATCH] gnu: Add ruby-gherkin3 pjotr.public12
2015-09-15 14:55 ` Thompson, David
@ 2015-09-15 18:37 ` Thompson, David
1 sibling, 0 replies; 3+ messages in thread
From: Thompson, David @ 2015-09-15 18:37 UTC (permalink / raw)
To: Pjotr Prins; +Cc: guix-devel
On Tue, Sep 15, 2015 at 10:48 AM, <pjotr.public12@thebird.nl> wrote:
> * gnu/packages/ruby.scm (ruby-gherkin3): New variable.
Fixed up and pushed. Thanks!
- Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-15 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-15 14:48 [PATCH] gnu: Add ruby-gherkin3 pjotr.public12
2015-09-15 14:55 ` Thompson, David
2015-09-15 18:37 ` Thompson, David
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).