From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Thompson, David" <dthompson2@worcester.edu>
Subject: Re: [PATCH] gnu: Add ruby-gherkin3
Date: Tue, 15 Sep 2015 10:55:19 -0400
Message-ID: <CAJ=RwfZUgSK-uLAmKJwCweaSBsQXuU93CgOexT=CtwJW0-RZ6g@mail.gmail.com>
References: <55f82fc3.O6mBJ915uAoK5FcU%pjotr.public12@thebird.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33441)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1Zbrdj-0008Fn-IK
	for guix-devel@gnu.org; Tue, 15 Sep 2015 10:55:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1Zbrdg-0002FI-15
	for guix-devel@gnu.org; Tue, 15 Sep 2015 10:55:23 -0400
Received: from mail-yk0-f176.google.com ([209.85.160.176]:33284)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1Zbrdf-0002FA-UU
	for guix-devel@gnu.org; Tue, 15 Sep 2015 10:55:19 -0400
Received: by ykft14 with SMTP id t14so36099246ykf.0
	for <guix-devel@gnu.org>; Tue, 15 Sep 2015 07:55:19 -0700 (PDT)
In-Reply-To: <55f82fc3.O6mBJ915uAoK5FcU%pjotr.public12@thebird.nl>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel <guix-devel@gnu.org>

On Tue, Sep 15, 2015 at 10:48 AM,  <pjotr.public12@thebird.nl> wrote:
> * gnu/packages/ruby.scm (ruby-gherkin3): New variable.

Looks good to me.  Just minor comments below.

> ---
>  gnu/packages/ruby.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index ee0acc8..4756cd4 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -1124,3 +1124,28 @@ it unifies the API for web servers, web frameworks, and software in between
>  into a single method call.")
>      (home-page "http://rack.github.io/")
>      (license license:expat)))
> +
> +(define-public ruby-gherkin3
> +  (package
> +    (name "ruby-gherkin3")
> +    (version "3.1.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (rubygems-uri "gherkin3" version))
> +        (sha256
> +          (base32
> +            "0xsyxhqa1gwcxzvsdy4didaiq5vam8ma3fbwbw2w60via4k6r1z9"))))
> +    (build-system ruby-build-system)
> +    (native-inputs
> +     `(("bundler" ,bundler)
> +       ("ruby-rspec" ,ruby-rspec)))

Let's remove rspec since we aren't running tests

> +    (arguments
> +     '(#:tests? #f)) ; needs simplecov, among others
> +    (synopsis "Gherkin parser")

Maybe "Gherkin parser for Ruby"

> +    (description "Gherkin 3 is a parser and compiler for the Gherkin
> +language.  It is intended to replace Gherkin 2 and be used by all
> +Cucumber implementations to parse .feature files.")
> +    (home-page
> +      "https://github.com/cucumber/gherkin3")

Move to same line as 'home-page'.

> +    (license expat)))

Needs prefix: license:expat

> --
> 2.4.3
>
>

- Dave