unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Updating Mono
@ 2019-12-01  4:12 Brett Gilio
  2019-12-01 18:52 ` Gábor Boskovits
  0 siblings, 1 reply; 2+ messages in thread
From: Brett Gilio @ 2019-12-01  4:12 UTC (permalink / raw)
  To: guix-devel


Hey all, I am currently working on updating the mono package that was
first placed in our package definitions by Jan Nieuwenhuizen I believe.

I am currently running into an issue where I am not able to understand
which tests are failing, and thus how to disable them. By the looks of
it, I can borrow the method of disabling tests used in the original
recipe.

Here is what I have for the updated package

--8<---------------cut here---------------start------------->8---
(define-public mono-6.4
  (package
    (name "mono")
    (version "6.4.0.198")
    (source (origin
              (method url-fetch)
              (uri (string-append "http://download.mono-project.com/sources/mono/mono-"
                                  version
                                  ".tar.xz"))
              (sha256
               (base32
                "1sn2fy49hr7acgy0cbf2r8cagis179ym63ryifgnzqr54n15426h"))))
    (build-system gnu-build-system)
    (arguments
     `(#:parallel-tests? #f ; running tests in parallel fails
       #:phases
       (modify-phases %standard-phases
         (replace 'bootstrap
           (lambda _
             (copy-file "mono/mini/Makefile.am.in" "mono/mini/Makefile.in")
             (invoke "autoreconf" "-vfi"))))))
    (native-inputs
     `(("gettext" ,gettext-minimal)
       ("glib" ,glib)
       ("which" ,which)
       ("cmake" ,cmake)
       ("libtool" ,libtool)
       ("autoconf" ,autoconf)
       ("automake" ,automake)
       ("libxslt" ,libxslt)
       ("perl" ,perl)
       ("python" ,python-2)))
    (synopsis "Compiler and libraries for the C# programming language")
    (description "Mono is a compiler, vm, debugger and set of libraries for
C#, a C-style programming language from Microsoft that is very similar to
Java.")
    (home-page "https://www.mono-project.com/")
    (license license:x11)))

(define-public mono mono-6.4)
--8<---------------cut here---------------end--------------->8---

Here is the point in the logs where things get a little screwy:

--8<---------------cut here---------------start------------->8---
....
4 test(s) passed, 0 test(s) did not pass.
make[6]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
make[6]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
Removing empty logs...
find . '(' -name "*.stdout" -o -name "*.stderr" ')' -size 0 -exec rm {} \;
make[6]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
make[6]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
make -C testing_gac run-test
make[7]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_gac'
true
make test-app-both
make[8]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_gac'
make[8]: *** No rule to make target 'app-both.cs', needed by 'app-both.exe'.  Stop.
make[8]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_gac'
make[7]: *** [Makefile:681: run-test] Error 2
make[7]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_gac'
make[6]: *** [Makefile:3494: runtest-gac-loading] Error 2
make[6]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
make[6]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
make -C assembly-load-reference run-test
make[7]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-load-reference'
true
make run-assembly-load-reference-tests
make[8]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-load-reference'
make[8]: *** No rule to make target 'samedir/LoadFromMain.exe', needed by 'run-assembly-load-reference-tests'.  Stop.
make[8]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-load-reference'
make[7]: *** [Makefile:681: run-test] Error 2
make[7]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-load-reference'
make[6]: *** [Makefile:3500: runtest-assembly-load-reference] Error 2
make[6]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
make[5]: *** [Makefile:2663: check-local] Error 1
make[5]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
make[4]: *** [Makefile:2516: check-am] Error 2
make[4]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
make[3]: *** [Makefile:2363: check-recursive] Error 1
make[3]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
make[2]: *** [Makefile:2518: check] Error 2
make[2]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
make[1]: *** [Makefile:515: check-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono'
make: *** [Makefile:589: check-recursive] Error 1

Test suite failed, dumping logs.
command "make" "check" failed with status 2
--8<---------------cut here---------------end--------------->8---

I notice in when keeping the failing build that things like app-both.cs
are not found in the kept /tmp, but it is found in the source
repository upstream.
https://github.com/mono/mono/blob/master/mono/tests/testing_gac/app-both.cs

That might be part of the issue, but I am sure the issue is greater than
that.

Anyways, any insight into how to get the failing tests to fail more
elegantly would be appreciated!

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Updating Mono
  2019-12-01  4:12 Updating Mono Brett Gilio
@ 2019-12-01 18:52 ` Gábor Boskovits
  0 siblings, 0 replies; 2+ messages in thread
From: Gábor Boskovits @ 2019-12-01 18:52 UTC (permalink / raw)
  To: Brett Gilio; +Cc: Guix-devel

[-- Attachment #1: Type: text/plain, Size: 6387 bytes --]

Hello,

Brett Gilio <brettg@posteo.net> ezt írta (időpont: 2019. dec. 1., Vas 5:13):

>
> Hey all, I am currently working on updating the mono package that was
> first placed in our package definitions by Jan Nieuwenhuizen I believe.
>
> I am currently running into an issue where I am not able to understand
> which tests are failing, and thus how to disable them. By the looks of
> it, I can borrow the method of disabling tests used in the original
> recipe.
>
> Here is what I have for the updated package
>
> --8<---------------cut here---------------start------------->8---
> (define-public mono-6.4
>   (package
>     (name "mono")
>     (version "6.4.0.198")
>     (source (origin
>               (method url-fetch)
>               (uri (string-append "
> http://download.mono-project.com/sources/mono/mono-"
>                                   version
>                                   ".tar.xz"))
>               (sha256
>                (base32
>                 "1sn2fy49hr7acgy0cbf2r8cagis179ym63ryifgnzqr54n15426h"))))
>     (build-system gnu-build-system)
>     (arguments
>      `(#:parallel-tests? #f ; running tests in parallel fails
>        #:phases
>        (modify-phases %standard-phases
>          (replace 'bootstrap
>            (lambda _
>              (copy-file "mono/mini/Makefile.am.in"
> "mono/mini/Makefile.in")
>              (invoke "autoreconf" "-vfi"))))))
>     (native-inputs
>      `(("gettext" ,gettext-minimal)
>        ("glib" ,glib)
>        ("which" ,which)
>        ("cmake" ,cmake)
>        ("libtool" ,libtool)
>        ("autoconf" ,autoconf)
>        ("automake" ,automake)
>        ("libxslt" ,libxslt)
>        ("perl" ,perl)
>        ("python" ,python-2)))
>     (synopsis "Compiler and libraries for the C# programming language")
>     (description "Mono is a compiler, vm, debugger and set of libraries for
> C#, a C-style programming language from Microsoft that is very similar to
> Java.")
>     (home-page "https://www.mono-project.com/")
>     (license license:x11)))
>
> (define-public mono mono-6.4)
> --8<---------------cut here---------------end--------------->8---
>
> Here is the point in the logs where things get a little screwy:
>
> --8<---------------cut here---------------start------------->8---
> ....
> 4 test(s) passed, 0 test(s) did not pass.
> make[6]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> make[6]: Entering directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> Removing empty logs...
> find . '(' -name "*.stdout" -o -name "*.stderr" ')' -size 0 -exec rm {} \;
> make[6]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> make[6]: Entering directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> make -C testing_gac run-test
> make[7]: Entering directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_gac'
> true
> make test-app-both
> make[8]: Entering directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_gac'
> make[8]: *** No rule to make target 'app-both.cs', needed by
> 'app-both.exe'.  Stop.
> make[8]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_gac'
> make[7]: *** [Makefile:681: run-test] Error 2
> make[7]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_gac'
> make[6]: *** [Makefile:3494: runtest-gac-loading] Error 2
> make[6]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> make[6]: Entering directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> make -C assembly-load-reference run-test
> make[7]: Entering directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-load-reference'
> true
> make run-assembly-load-reference-tests
> make[8]: Entering directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-load-reference'
> make[8]: *** No rule to make target 'samedir/LoadFromMain.exe', needed by
> 'run-assembly-load-reference-tests'.  Stop.
> make[8]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-load-reference'
> make[7]: *** [Makefile:681: run-test] Error 2
> make[7]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-load-reference'
> make[6]: *** [Makefile:3500: runtest-assembly-load-reference] Error 2
> make[6]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> make[5]: *** [Makefile:2663: check-local] Error 1
> make[5]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> make[4]: *** [Makefile:2516: check-am] Error 2
> make[4]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> make[3]: *** [Makefile:2363: check-recursive] Error 1
> make[3]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> make[2]: *** [Makefile:2518: check] Error 2
> make[2]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests'
> make[1]: *** [Makefile:515: check-recursive] Error 1
> make[1]: Leaving directory
> '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono'
> make: *** [Makefile:589: check-recursive] Error 1
>
> Test suite failed, dumping logs.
> command "make" "check" failed with status 2
> --8<---------------cut here---------------end--------------->8---
>
> I notice in when keeping the failing build that things like app-both.cs
> are not found in the kept /tmp, but it is found in the source
> repository upstream.
> https://github.com/mono/mono/blob/master/mono/tests/testing_gac/app-both.cs
>
> That might be part of the issue, but I am sure the issue is greater than
> that.
>
Istm that there is no snippet in the package def, so the source should be
the same. I would try to have a look after unpack, and after autoreconf to
see what is going on.

>
> Anyways, any insight into how to get the failing tests to fail more
> elegantly would be appreciated!
>
> --
> Brett M. Gilio
> https://git.sr.ht/~brettgilio/

Best regards,
g_bor

>
>
>

[-- Attachment #2: Type: text/html, Size: 8381 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-01 18:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-01  4:12 Updating Mono Brett Gilio
2019-12-01 18:52 ` Gábor Boskovits

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).