From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: Updating Mono Date: Sun, 1 Dec 2019 19:52:15 +0100 Message-ID: References: <87a78cn0ox.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000fd94350598a8f6dc" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:59649) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibUKg-00036y-2f for guix-devel@gnu.org; Sun, 01 Dec 2019 13:52:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibUKd-0005Cf-Iu for guix-devel@gnu.org; Sun, 01 Dec 2019 13:52:33 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:36711) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibUKd-00058m-6v for guix-devel@gnu.org; Sun, 01 Dec 2019 13:52:31 -0500 Received: by mail-ed1-x532.google.com with SMTP id j17so13838345edp.3 for ; Sun, 01 Dec 2019 10:52:30 -0800 (PST) In-Reply-To: <87a78cn0ox.fsf@posteo.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Brett Gilio Cc: Guix-devel --000000000000fd94350598a8f6dc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, Brett Gilio ezt =C3=ADrta (id=C5=91pont: 2019. dec. 1.,= Vas 5:13): > > Hey all, I am currently working on updating the mono package that was > first placed in our package definitions by Jan Nieuwenhuizen I believe. > > I am currently running into an issue where I am not able to understand > which tests are failing, and thus how to disable them. By the looks of > it, I can borrow the method of disabling tests used in the original > recipe. > > Here is what I have for the updated package > > --8<---------------cut here---------------start------------->8--- > (define-public mono-6.4 > (package > (name "mono") > (version "6.4.0.198") > (source (origin > (method url-fetch) > (uri (string-append " > http://download.mono-project.com/sources/mono/mono-" > version > ".tar.xz")) > (sha256 > (base32 > "1sn2fy49hr7acgy0cbf2r8cagis179ym63ryifgnzqr54n15426h")))= ) > (build-system gnu-build-system) > (arguments > `(#:parallel-tests? #f ; running tests in parallel fails > #:phases > (modify-phases %standard-phases > (replace 'bootstrap > (lambda _ > (copy-file "mono/mini/Makefile.am.in" > "mono/mini/Makefile.in") > (invoke "autoreconf" "-vfi")))))) > (native-inputs > `(("gettext" ,gettext-minimal) > ("glib" ,glib) > ("which" ,which) > ("cmake" ,cmake) > ("libtool" ,libtool) > ("autoconf" ,autoconf) > ("automake" ,automake) > ("libxslt" ,libxslt) > ("perl" ,perl) > ("python" ,python-2))) > (synopsis "Compiler and libraries for the C# programming language") > (description "Mono is a compiler, vm, debugger and set of libraries f= or > C#, a C-style programming language from Microsoft that is very similar to > Java.") > (home-page "https://www.mono-project.com/") > (license license:x11))) > > (define-public mono mono-6.4) > --8<---------------cut here---------------end--------------->8--- > > Here is the point in the logs where things get a little screwy: > > --8<---------------cut here---------------start------------->8--- > .... > 4 test(s) passed, 0 test(s) did not pass. > make[6]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > make[6]: Entering directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > Removing empty logs... > find . '(' -name "*.stdout" -o -name "*.stderr" ')' -size 0 -exec rm {} \= ; > make[6]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > make[6]: Entering directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > make -C testing_gac run-test > make[7]: Entering directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_g= ac' > true > make test-app-both > make[8]: Entering directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_g= ac' > make[8]: *** No rule to make target 'app-both.cs', needed by > 'app-both.exe'. Stop. > make[8]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_g= ac' > make[7]: *** [Makefile:681: run-test] Error 2 > make[7]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/testing_g= ac' > make[6]: *** [Makefile:3494: runtest-gac-loading] Error 2 > make[6]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > make[6]: Entering directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > make -C assembly-load-reference run-test > make[7]: Entering directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-= load-reference' > true > make run-assembly-load-reference-tests > make[8]: Entering directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-= load-reference' > make[8]: *** No rule to make target 'samedir/LoadFromMain.exe', needed by > 'run-assembly-load-reference-tests'. Stop. > make[8]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-= load-reference' > make[7]: *** [Makefile:681: run-test] Error 2 > make[7]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests/assembly-= load-reference' > make[6]: *** [Makefile:3500: runtest-assembly-load-reference] Error 2 > make[6]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > make[5]: *** [Makefile:2663: check-local] Error 1 > make[5]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > make[4]: *** [Makefile:2516: check-am] Error 2 > make[4]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > make[3]: *** [Makefile:2363: check-recursive] Error 1 > make[3]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > make[2]: *** [Makefile:2518: check] Error 2 > make[2]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono/tests' > make[1]: *** [Makefile:515: check-recursive] Error 1 > make[1]: Leaving directory > '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6.4.0.198/mono' > make: *** [Makefile:589: check-recursive] Error 1 > > Test suite failed, dumping logs. > command "make" "check" failed with status 2 > --8<---------------cut here---------------end--------------->8--- > > I notice in when keeping the failing build that things like app-both.cs > are not found in the kept /tmp, but it is found in the source > repository upstream. > https://github.com/mono/mono/blob/master/mono/tests/testing_gac/app-both.= cs > > That might be part of the issue, but I am sure the issue is greater than > that. > Istm that there is no snippet in the package def, so the source should be the same. I would try to have a look after unpack, and after autoreconf to see what is going on. > > Anyways, any insight into how to get the failing tests to fail more > elegantly would be appreciated! > > -- > Brett M. Gilio > https://git.sr.ht/~brettgilio/ Best regards, g_bor > > > --000000000000fd94350598a8f6dc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

Brett Gilio <brettg@posteo.net> ezt =C3=ADrta (id=C5=91pont: 2019. dec. 1., = Vas 5:13):

Hey all, I am currently working on updating the mono package that was
first placed in our package definitions by Jan Nieuwenhuizen I believe.

I am currently running into an issue where I am not able to understand
which tests are failing, and thus how to disable them. By the looks of
it, I can borrow the method of disabling tests used in the original
recipe.

Here is what I have for the updated package

--8<---------------cut here---------------start------------->8---
(define-public mono-6.4
=C2=A0 (package
=C2=A0 =C2=A0 (name "mono")
=C2=A0 =C2=A0 (version "6.4.0.198")
=C2=A0 =C2=A0 (source (origin
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (method url-fetch)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri (string-append "= http://download.mono-project.com/sourc= es/mono/mono-"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 version
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ".tar.xz"))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sha256
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(base32
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "1sn2fy49hr7ac= gy0cbf2r8cagis179ym63ryifgnzqr54n15426h"))))
=C2=A0 =C2=A0 (build-system gnu-build-system)
=C2=A0 =C2=A0 (arguments
=C2=A0 =C2=A0 =C2=A0`(#:parallel-tests? #f ; running tests in parallel fail= s
=C2=A0 =C2=A0 =C2=A0 =C2=A0#:phases
=C2=A0 =C2=A0 =C2=A0 =C2=A0(modify-phases %standard-phases
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(replace 'bootstrap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambda _
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(copy-file "mono/mini/= Makefile.am.in" "mono/mini/Makefile.in")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(invoke "autoreconf&qu= ot; "-vfi"))))))
=C2=A0 =C2=A0 (native-inputs
=C2=A0 =C2=A0 =C2=A0`(("gettext" ,gettext-minimal)
=C2=A0 =C2=A0 =C2=A0 =C2=A0("glib" ,glib)
=C2=A0 =C2=A0 =C2=A0 =C2=A0("which" ,which)
=C2=A0 =C2=A0 =C2=A0 =C2=A0("cmake" ,cmake)
=C2=A0 =C2=A0 =C2=A0 =C2=A0("libtool" ,libtool)
=C2=A0 =C2=A0 =C2=A0 =C2=A0("autoconf" ,autoconf)
=C2=A0 =C2=A0 =C2=A0 =C2=A0("automake" ,automake)
=C2=A0 =C2=A0 =C2=A0 =C2=A0("libxslt" ,libxslt)
=C2=A0 =C2=A0 =C2=A0 =C2=A0("perl" ,perl)
=C2=A0 =C2=A0 =C2=A0 =C2=A0("python" ,python-2)))
=C2=A0 =C2=A0 (synopsis "Compiler and libraries for the C# programming= language")
=C2=A0 =C2=A0 (description "Mono is a compiler, vm, debugger and set o= f libraries for
C#, a C-style programming language from Microsoft that is very similar to Java.")
=C2=A0 =C2=A0 (home-page "https://www.mono-project.com/= ")
=C2=A0 =C2=A0 (license license:x11)))

(define-public mono mono-6.4)
--8<---------------cut here---------------end--------------->8---

Here is the point in the logs where things get a little screwy:

--8<---------------cut here---------------start------------->8---
....
4 test(s) passed, 0 test(s) did not pass.
make[6]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests'
make[6]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-= 6.4.0.198/mono/tests'
Removing empty logs...
find . '(' -name "*.stdout" -o -name "*.stderr"= ')' -size 0 -exec rm {} \;
make[6]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests'
make[6]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-= 6.4.0.198/mono/tests'
make -C testing_gac run-test
make[7]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-= 6.4.0.198/mono/tests/testing_gac'
true
make test-app-both
make[8]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-= 6.4.0.198/mono/tests/testing_gac'
make[8]: *** No rule to make target 'app-both.cs', needed by 'a= pp-both.exe'.=C2=A0 Stop.
make[8]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests/testing_gac'
make[7]: *** [Makefile:681: run-test] Error 2
make[7]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests/testing_gac'
make[6]: *** [Makefile:3494: runtest-gac-loading] Error 2
make[6]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests'
make[6]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-= 6.4.0.198/mono/tests'
make -C assembly-load-reference run-test
make[7]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-= 6.4.0.198/mono/tests/assembly-load-reference'
true
make run-assembly-load-reference-tests
make[8]: Entering directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-= 6.4.0.198/mono/tests/assembly-load-reference'
make[8]: *** No rule to make target 'samedir/LoadFromMain.exe', nee= ded by 'run-assembly-load-reference-tests'.=C2=A0 Stop.
make[8]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests/assembly-load-reference'
make[7]: *** [Makefile:681: run-test] Error 2
make[7]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests/assembly-load-reference'
make[6]: *** [Makefile:3500: runtest-assembly-load-reference] Error 2
make[6]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests'
make[5]: *** [Makefile:2663: check-local] Error 1
make[5]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests'
make[4]: *** [Makefile:2516: check-am] Error 2
make[4]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests'
make[3]: *** [Makefile:2363: check-recursive] Error 1
make[3]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests'
make[2]: *** [Makefile:2518: check] Error 2
make[2]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono/tests'
make[1]: *** [Makefile:515: check-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-mono-6.4.0.198.drv-0/mono-6= .4.0.198/mono'
make: *** [Makefile:589: check-recursive] Error 1

Test suite failed, dumping logs.
command "make" "check" failed with status 2
--8<---------------cut here---------------end--------------->8---

I notice in when keeping the failing build that things like app-both.cs
are not found in the kept /tmp, but it is found in the source
repository upstream.
https://github= .com/mono/mono/blob/master/mono/tests/testing_gac/app-both.cs

That might be part of the issue, but I am sure the issue is greater than that.
Istm that there is no s= nippet in the package def, so the source should be the same. I would try to= have a look after unpack, and after autoreconf to see what is going on.

Anyways, any insight into how to get the failing tests to fail more
elegantly would be appreciated!

--
Brett M. Gilio
https://git.sr.ht/~brettgilio/
=
Best regards,
g_bor


--000000000000fd94350598a8f6dc--