unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Greg Hogan <code@greghogan.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org, Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: Re: Test parallelism with CMake
Date: Wed, 3 Nov 2021 10:47:39 -0400	[thread overview]
Message-ID: <CA+3U0ZkMYVGqocjx8zcFO2NhuapEXvJE6DYNgxBvUSMk3JkigA@mail.gmail.com> (raw)
In-Reply-To: <87a6is2fsx.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]

On Fri, Oct 29, 2021 at 8:09 AM Ludovic Courtès <ludo@gnu.org> wrote:

> Hi Greg,
>
> Greg Hogan <code@greghogan.com> skribis:
> > It seems that we should at a minimum document the issue in
> > cmake-build-system:check. We could patch cmake-build-system to enable
> test
> > parallelism and explicitly disable that setting for packages which
> succeed
> > before but fail after making the change. What do you think?
>
> I think we could make the change you made—running ‘ctest’—in
> ‘core-updates’.  If it turns out to be safer, we can have
> #:parallel-build? default to #f at the beginning in
> ‘cmake-build-system’.
>
> How does that sound?
>

Hi Liliana and Ludo’,

If the default is to disable parallel tests then it is unlikely that future
committers will be aware of, remember, and bother to enable the setting.
And once packages do override the default then there would be additional
future work to invert the default value.

I do not know how to obtain the list of packages using the
cmake-build-system.

The strategy looks to require multiple stages. First build and test the
packages and ignore current failures. As noted by Liliana, next build and
test the successful builds with ctest in serial. Hopefully no or few builds
are newly failing at this point. Lastly build and test with ctest in
parallel, and explicitly disable test parallelism for the failing builds.

Greg

[-- Attachment #2: Type: text/html, Size: 1933 bytes --]

  reply	other threads:[~2021-11-03 14:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09  7:56 Test parallelism with CMake Liliana Marie Prikler
2021-10-12 17:28 ` Greg Hogan
2021-10-22 13:10 ` Greg Hogan
2021-10-22 18:28   ` Liliana Marie Prikler
2021-10-29 12:09   ` Ludovic Courtès
2021-11-03 14:47     ` Greg Hogan [this message]
2021-11-03 17:58       ` Liliana Marie Prikler
  -- strict thread matches above, loose matches on Subject: below --
2021-10-08 11:07 Greg Hogan
2021-10-21 19:30 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+3U0ZkMYVGqocjx8zcFO2NhuapEXvJE6DYNgxBvUSMk3JkigA@mail.gmail.com \
    --to=code@greghogan.com \
    --cc=guix-devel@gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).