From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qNrDLFuhgmE+jwAAgWs5BA (envelope-from ) for ; Wed, 03 Nov 2021 15:48:59 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AItbKFuhgmGcbwAAbx9fmQ (envelope-from ) for ; Wed, 03 Nov 2021 14:48:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4E28C10D93 for ; Wed, 3 Nov 2021 15:48:59 +0100 (CET) Received: from localhost ([::1]:34668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miHZS-00033r-Fc for larch@yhetil.org; Wed, 03 Nov 2021 10:48:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miHYS-0001xA-2c for guix-devel@gnu.org; Wed, 03 Nov 2021 10:47:56 -0400 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]:40914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miHYO-0001gz-T4 for guix-devel@gnu.org; Wed, 03 Nov 2021 10:47:55 -0400 Received: by mail-il1-x12b.google.com with SMTP id k1so2778403ilo.7 for ; Wed, 03 Nov 2021 07:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=15Lh/AObV8qDq30D/iEL4fNEWwo0r+PpBAGxiZxyG0w=; b=fs/TNZmpsUujxvh7oD3UfP2n+amN5Anc6CkbdZh+RpVcQG5VQ9E5W9iz1TKkJ2kLz9 oeFqpu2J46pN4ufAlklvPdRO76f65lc0hsoYhjwpdjQwqTYiQbcfz/zP7muPFBZUQzy5 /qs55OiGQH3QBXRHYHgTbepKZyBQPDDCB6y9nDjJ3axJOxwjHEQ0oteWDSI2l4vW8TYD yhGSi0uJecPzyWCfAeUElrXaYAAGHsqVelwAsjAoKUwXAWqH/vQx2UO8hsJZ1PiWumKy va5rlho9+2oTxT4/DsQjTM53xHO74APqSbMSo6vgsXRVH/nK2cKqFAPGPjJIr5/SvBor 4OFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=15Lh/AObV8qDq30D/iEL4fNEWwo0r+PpBAGxiZxyG0w=; b=RBJw/GawL+amPZrBeeyLDuwAXCJomWKK3yqTn7pvo9fyj92VnFubt88yMEEaGu3guQ LmN+T9HjP3eRp5mH3uWTuPuJfNiIhA01Rn/57XkiFgrpf4Yw0Uh+XjlEHooHazXBzqnU G9I0ly6qph1OO94l+SsqS/eUrL6J+ZNVqhs5DgE7eJSJvPnmUWrPNK1dDqI1pp7pPQhj AGuyoT74qv1p7U8B38fmV47ZcUnhUTz+OTujrnyeGBB2akMHrwhSsa+Ze2gPAMMMaHV+ 3ZlT3RfL4wAq6knKJxF7nELyWqjyPT81qenpZwkMYf/LKU205+9pg4gM6VRZzbBxc22I lsAQ== X-Gm-Message-State: AOAM532HvI775k9hDpcjgDPYHDJaE8PF77TYZ/YmoGMZlA7haYDxL0N1 qxvehJEcH/tTezDBNrG4ZdmtU0SOoUM6HSnPGXqjBJxSaFYTIXXv X-Google-Smtp-Source: ABdhPJxGNqkT88dL9NwrxY1JbfB9/w7uFPTfrOUGdDuWbPp2GixuK8v/fhpPl2vuylZ9MlZ8UNymVl+bo5SKCJxYabw= X-Received: by 2002:a05:6e02:190f:: with SMTP id w15mr17244891ilu.197.1635950870693; Wed, 03 Nov 2021 07:47:50 -0700 (PDT) MIME-Version: 1.0 References: <3906845baca1424432c1fd5c3ab23c1400695b66.camel@gmail.com> <87a6is2fsx.fsf@gnu.org> In-Reply-To: <87a6is2fsx.fsf@gnu.org> From: Greg Hogan Date: Wed, 3 Nov 2021 10:47:39 -0400 Message-ID: Subject: Re: Test parallelism with CMake To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: multipart/alternative; boundary="00000000000084a18d05cfe37eba" Received-SPF: none client-ip=2607:f8b0:4864:20::12b; envelope-from=code@greghogan.com; helo=mail-il1-x12b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Liliana Marie Prikler Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635950939; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=15Lh/AObV8qDq30D/iEL4fNEWwo0r+PpBAGxiZxyG0w=; b=vBYovKncCn5x8+OV+oodvI9+LwcxWPDkG6lLF0vPgGBE5fNo68VtLCVi0X2WfysepXCz7y 9RUPp4YHkZ/m5JDFwhLKK8Fu/OTj7odtW554jR5suO1CozsBY8UABC27sJ2ZS5sw9mYWAG A0OJhCTMRedQaS1PhKu1xVumDFJBU+rn7Q2Ee6k6tqDbAit3pZH4Ln9h4pkHklkoR9/Nio Xvondg6/ccjR13d+OF1embLVupr/bltcuhj2j+851QNHoL4MQcRS3kNGRJdzu6BEwdxjA3 KTXMRz+ClSXNkcL60IyxQLSynKjiVzJ6JKiv6unm9GJqHqJwhuLVVIeLP/97Sw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635950939; a=rsa-sha256; cv=none; b=gSNh97i6nzY+mbRFD5SSZyOcZmIQvTORHVYkQ6/3eKM3NCvYV7htIttz2PzAIQgF6pUBML McwMJJimYnmsMOus1ihDGIu2n9bbrtwWeIxMoalwbG+8h2Lc9pFbgCS89bbp1CZ/9EEepS crvYQ2gEeVjNd4N6Fj7nkh5g+XsNd1hK4Dtxiagjawq1gTMc36p8uzfTADhSnXO4a7mAzI m72seI1K6XsQBsNX8PngiD5U90aImkVqZtEVcrKLObrimhYugZYrbpCYTOd/e8Mlocn9EQ Yv9YsbJ5louxDGh1mfJsCWHLMGj6vvTvw4F6EN/2iTmH7S8MsFo6pNIEMajTWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=greghogan-com.20210112.gappssmtp.com header.s=20210112 header.b="fs/TNZmp"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=greghogan-com.20210112.gappssmtp.com header.s=20210112 header.b="fs/TNZmp"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 4E28C10D93 X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: W1wzz9fKeNC7 --00000000000084a18d05cfe37eba Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 29, 2021 at 8:09 AM Ludovic Court=C3=A8s wrote: > Hi Greg, > > Greg Hogan skribis: > > It seems that we should at a minimum document the issue in > > cmake-build-system:check. We could patch cmake-build-system to enable > test > > parallelism and explicitly disable that setting for packages which > succeed > > before but fail after making the change. What do you think? > > I think we could make the change you made=E2=80=94running =E2=80=98ctest= =E2=80=99=E2=80=94in > =E2=80=98core-updates=E2=80=99. If it turns out to be safer, we can have > #:parallel-build? default to #f at the beginning in > =E2=80=98cmake-build-system=E2=80=99. > > How does that sound? > Hi Liliana and Ludo=E2=80=99, If the default is to disable parallel tests then it is unlikely that future committers will be aware of, remember, and bother to enable the setting. And once packages do override the default then there would be additional future work to invert the default value. I do not know how to obtain the list of packages using the cmake-build-system. The strategy looks to require multiple stages. First build and test the packages and ignore current failures. As noted by Liliana, next build and test the successful builds with ctest in serial. Hopefully no or few builds are newly failing at this point. Lastly build and test with ctest in parallel, and explicitly disable test parallelism for the failing builds. Greg --00000000000084a18d05cfe37eba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Oct 29, 2021 at 8:09 AM Ludovic C= ourt=C3=A8s <ludo@gnu.org> wrote:=
Hi Greg,

Greg Hogan <code= @greghogan.com> skribis:
> It seems that we should at a minimum document the issue in
> cmake-build-system:check. We could patch cmake-build-system to enable = test
> parallelism and explicitly disable that setting for packages which suc= ceed
> before but fail after making the change. What do you think?

I think we could make the change you made=E2=80=94running =E2=80=98ctest=E2= =80=99=E2=80=94in
=E2=80=98core-updates=E2=80=99.=C2=A0 If it turns out to be safer, we can h= ave
#:parallel-build? default to #f at the beginning in
=E2=80=98cmake-build-system=E2=80=99.

How does that sound?

Hi Liliana and Lud= o=E2=80=99,

If the default is to disable paral= lel tests then it is unlikely that future committers will be aware of, reme= mber, and bother to enable the setting. And once packages do override the d= efault then there would be additional future work to invert the default val= ue.

I do not know how to obtain the list of packag= es using the cmake-build-system.

The strategy look= s to require multiple stages. First build and test the packages and ignore = current failures. As noted by Liliana, next build and test the successful b= uilds with ctest in serial. Hopefully no or few builds are newly failing at= this point. Lastly build and test with ctest in parallel, and explicitly d= isable test parallelism for the failing builds.

Gr= eg
--00000000000084a18d05cfe37eba--