unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Using the pyproject-build-system
@ 2024-01-15 23:19 Troy Figiel
  2024-01-17 16:02 ` Simon Tournier
  2024-01-17 19:20 ` Maxim Cournoyer
  0 siblings, 2 replies; 3+ messages in thread
From: Troy Figiel @ 2024-01-15 23:19 UTC (permalink / raw)
  To: guix-devel


[-- Attachment #1.1.1: Type: text/plain, Size: 1084 bytes --]

Hi Guix/Python team,

My fix for python-requests-kerberos was pushed today (thanks Oleg!) and
I thought it would be an appropriate moment to ask about the
pyproject-build-system. In short, is the pyproject-build-system a
preferable default over the python-build-system? The manual states
"experimental", but "encouraged to try it", leaving me wondering which
one to use when.

And in long:

Although not fully PEP 517-compliant according the documentation, the
pyproject-build-system does seem to fall back to setuptools.build_meta
if the pyproject.toml is missing. Contrary to what the name implies to
me, it can therefore also be used for packages with only a setup.py file.

This usually leads to slicker definitions, since quite a few packages
seem to only use pytest as their testing suite and in these cases the
pyproject-build-system does not require an override of the check phase.

Should I therefore always try to use the pyproject-build-system instead
of the python-build-system, or is there some different guideline to
follow?

Best wishes,

Troy

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6367 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Using the pyproject-build-system
  2024-01-15 23:19 Using the pyproject-build-system Troy Figiel
@ 2024-01-17 16:02 ` Simon Tournier
  2024-01-17 19:20 ` Maxim Cournoyer
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Tournier @ 2024-01-17 16:02 UTC (permalink / raw)
  To: Troy Figiel, guix-devel

Hi,

On Tue, 16 Jan 2024 at 00:19, Troy Figiel <troy@troyfigiel.com> wrote:

> Although not fully PEP 517-compliant according the documentation, the
> pyproject-build-system does seem to fall back to setuptools.build_meta
> if the pyproject.toml is missing. Contrary to what the name implies to
> me, it can therefore also be used for packages with only a setup.py file.

My understanding is that PEP 517 will be the default buitin way for
building Python project, and pyproject-build-system is an implementation
of such PEP 517.  Somehow, the adoption of PEP 517 by Python projects
will imply more Guix packages using pyproject-build-system.

In addition, one (and tangential) longer term for building Python
packages using Guix is rely on one build-system, namely
pyproject-build-system.  Hence maybe this unclear situation.

Cheers,
simon


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Using the pyproject-build-system
  2024-01-15 23:19 Using the pyproject-build-system Troy Figiel
  2024-01-17 16:02 ` Simon Tournier
@ 2024-01-17 19:20 ` Maxim Cournoyer
  1 sibling, 0 replies; 3+ messages in thread
From: Maxim Cournoyer @ 2024-01-17 19:20 UTC (permalink / raw)
  To: Troy Figiel; +Cc: guix-devel

Hi,

Troy Figiel <troy@troyfigiel.com> writes:

> Hi Guix/Python team,
>
> My fix for python-requests-kerberos was pushed today (thanks Oleg!) and
> I thought it would be an appropriate moment to ask about the
> pyproject-build-system. In short, is the pyproject-build-system a
> preferable default over the python-build-system? The manual states
> "experimental", but "encouraged to try it", leaving me wondering which
> one to use when.
>
> And in long:
>
> Although not fully PEP 517-compliant according the documentation, the
> pyproject-build-system does seem to fall back to setuptools.build_meta
> if the pyproject.toml is missing. Contrary to what the name implies to
> me, it can therefore also be used for packages with only a setup.py file.
>
> This usually leads to slicker definitions, since quite a few packages
> seem to only use pytest as their testing suite and in these cases the
> pyproject-build-system does not require an override of the check phase.
>
> Should I therefore always try to use the pyproject-build-system instead
> of the python-build-system, or is there some different guideline to
> follow?

I think pyproject-build-system is often more convenient, such as for
running the test suite, where it automatically figures out whether
pytest or something else should be run.

It's fine to use it as a replacement for python-build-system until it
becomes the default, it you want!

-- 
Thanks,
Maxim


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-17 20:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-15 23:19 Using the pyproject-build-system Troy Figiel
2024-01-17 16:02 ` Simon Tournier
2024-01-17 19:20 ` Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).