* [PATCH] substitute: Close the download port after substitution finished.
@ 2017-09-16 7:31 宋文武
2017-09-17 20:12 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: 宋文武 @ 2017-09-16 7:31 UTC (permalink / raw)
To: guix-devel
* guix/scripts/substitute.scm (progress-substitution): Call 'close-port'
after 'restore-file'.
---
guix/scripts/substitute.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
index 19212d749..3dcf42d0d 100755
--- a/guix/scripts/substitute.scm
+++ b/guix/scripts/substitute.scm
@@ -961,6 +961,7 @@ DESTINATION as a nar file. Verify the substitute against ACL."
progress)))
;; Unpack the Nar at INPUT into DESTINATION.
(restore-file input destination)
+ (close-port input)
;; Skip a line after what 'progress-reporter/file' printed, and another
;; one to visually separate substitutions.
--
2.13.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] substitute: Close the download port after substitution finished.
2017-09-16 7:31 [PATCH] substitute: Close the download port after substitution finished 宋文武
@ 2017-09-17 20:12 ` Ludovic Courtès
2017-09-18 11:11 ` 宋文武
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2017-09-17 20:12 UTC (permalink / raw)
To: 宋文武; +Cc: guix-devel
Hi 宋文武,
宋文武 <iyzsong@member.fsf.org> skribis:
> * guix/scripts/substitute.scm (progress-substitution): Call 'close-port'
> after 'restore-file'.
Good catch, please push!
How did you notice?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] substitute: Close the download port after substitution finished.
2017-09-17 20:12 ` Ludovic Courtès
@ 2017-09-18 11:11 ` 宋文武
0 siblings, 0 replies; 3+ messages in thread
From: 宋文武 @ 2017-09-18 11:11 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
ludo@gnu.org (Ludovic Courtès) writes:
> Hi 宋文武,
>
> 宋文武 <iyzsong@member.fsf.org> skribis:
>
>> * guix/scripts/substitute.scm (progress-substitution): Call 'close-port'
>> after 'restore-file'.
>
> Good catch, please push!
>
> How did you notice?
I meet it when test my progress reporter patch at
<https://lists.gnu.org/archive/html/guix-devel/2017-09/msg00190.html>,
which will write the last report to console after close
'progress-report-port'.
Pushed, thanks for the review!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-18 11:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-16 7:31 [PATCH] substitute: Close the download port after substitution finished 宋文武
2017-09-17 20:12 ` Ludovic Courtès
2017-09-18 11:11 ` 宋文武
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).