[PATCH] substitute: Close the download port after substitution finished.

[PATCH] substitute: Close the download port after substitution finished.

[宋文武]

* guix/scripts/substitute.scm (progress-substitution): Call 'close-port'
after 'restore-file'.
---
 guix/scripts/substitute.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
index 19212d749..3dcf42d0d 100755
--- a/guix/scripts/substitute.scm
+++ b/guix/scripts/substitute.scm
@@ -961,6 +961,7 @@ DESTINATION as a nar file.  Verify the substitute against ACL."
                                       progress)))
       ;; Unpack the Nar at INPUT into DESTINATION.
       (restore-file input destination)
+      (close-port input)
 
       ;; Skip a line after what 'progress-reporter/file' printed, and another
       ;; one to visually separate substitutions.
-- 
2.13.3

Re: [PATCH] substitute: Close the download port after substitution finished.

[Ludovic Courtès]

Hi 宋文武,

宋文武 <iyzsong@member.fsf.org> skribis:

> * guix/scripts/substitute.scm (progress-substitution): Call 'close-port'
> after 'restore-file'.

Good catch, please push!

How did you notice?

Thanks,
Ludo’.

Re: [PATCH] substitute: Close the download port after substitution finished.

[宋文武]

ludo@gnu.org (Ludovic Courtès) writes:

> Hi 宋文武,
>
> 宋文武 <iyzsong@member.fsf.org> skribis:
>
>> * guix/scripts/substitute.scm (progress-substitution): Call 'close-port'
>> after 'restore-file'.
>
> Good catch, please push!
>
> How did you notice?

I meet it when test my progress reporter patch at
<https://lists.gnu.org/archive/html/guix-devel/2017-09/msg00190.html>,
which will write the last report to console after close
'progress-report-port'.


Pushed, thanks for the review!