From: Alex Kost <alezost@gmail.com>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add gparted.
Date: Sat, 28 May 2016 22:15:18 +0300 [thread overview]
Message-ID: <87y46uyoxl.fsf@gmail.com> (raw)
In-Reply-To: <87r3cmxc9g.fsf@gnu.org> (Roel Janssen's message of "Sat, 28 May 2016 20:34:19 +0200")
Roel Janssen (2016-05-28 21:34 +0300) wrote:
> Hello Leo,
>
> Thank you for your quick response.
>
> Leo Famulari writes:
>
>> On Sat, May 28, 2016 at 05:52:16PM +0200, Roel Janssen wrote:
>>> Dear Guix,
>>>
>>> I wonder if my ChangeLog-format commit message is OK this way.
>>
>> How about wording it as in bf50f7b5870? I don't think it's necessary to
>> list the affected packages if it applies to the entire module.
>
> Right. I had looked for a similar change but could not find one.
> Thanks for pointing this one out.
>
> Would it perhaps be better if I split the license prefix changes and
> the addition of gparted in two separate patches?
Yes, these are 2 different things, so separating them would be the best,
I think.
--
Alex
next prev parent reply other threads:[~2016-05-28 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 15:52 [PATCH] gnu: Add gparted Roel Janssen
2016-05-28 16:18 ` Leo Famulari
2016-05-28 18:34 ` Roel Janssen
2016-05-28 19:15 ` Alex Kost [this message]
2016-05-28 19:28 ` Leo Famulari
2016-05-28 19:41 ` Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y46uyoxl.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).