Re: [PATCH] gnu: Add gparted.

[Roel Janssen <roel@gnu.org>]

Hello Leo,

Thank you for your quick response.

Leo Famulari writes:

> On Sat, May 28, 2016 at 05:52:16PM +0200, Roel Janssen wrote:
>> Dear Guix,
>> 
>> I wonder if my ChangeLog-format commit message is OK this way.
>
> How about wording it as in bf50f7b5870? I don't think it's necessary to
> list the affected packages if it applies to the entire module.

Right.  I had looked for a similar change but could not find one.
Thanks for pointing this one out.

Would it perhaps be better if I split the license prefix changes and
the addition of gparted in two separate patches?

>> Also, is it OK to push this patch for GParted?  To avoid a name
>> collision for 'zlib' (both a license and a package), I added the
>> usual 'license:' prefix to the other packages in this file.
>
> Okay!
>
>> * gnu/packages/disk.scm (gparted): New variable.
>> (parted, fdisk, ddrescue, dosfstools, sdparm, idle3-tools): Avoid ambiguity by
>> adding a prefix to license symbols.
>
> It runs and finds my partitions! I didn't try to actually do anything...

I tested with a USB drive.  I could create a new partition table and a
new partition.

>> +    (arguments
>> +     `(#:tests? #f ; Tests require a network connection.
>
> Is it just a small subset of the tests that require the network? Maybe
> we could disable only those tests?

It seems all tests need to download DTDs from various places on the
internet.  The tests are related to the use of Scrollkeeper (which I
disabled).

As far as I can see there are no unit tests for the actual code.

>> +       #:configure-flags '("--disable-scrollkeeper")))
>
> I'm not sure what this means. Can you leave a comment explaining it?

Of course!  I'm not completely familiar with Scrollkeeper (although I
also wrote a package recipe for it), but what I understand is that it is
a program to manage various formats of documentation, and keep a central
database that links to various forms of documentation.

I added the following comment, but I think explaining the ins and outs of
Scrollkeeper goes too far.  Is the comment good enough?

+       ;; We don't use scrollkeeper elsewhere, so disable updating the
+       ;; scrollkeeper database with documentation from GParted.
+       #:configure-flags '("--disable-scrollkeeper")))

>> +    (inputs
>> +     `(("util-linux" ,util-linux)
>
> Since util-linux is just a mish-mash of miscellaneous utilities, I like
> it when packagers leave a hint of what it's being used for, either in a
> comment, or by naming it after the used library, as in the jack-1
> package.

I followed the example of jack-1 here, because for GParted, it's also
libuuid it takes from the util-linux package.

Kind regards,
Roel Janssen