From: "Ludovic Courtès" <ludo@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: guix: Simplify and robustify lzread!.
Date: Fri, 10 May 2019 23:40:50 +0200 [thread overview]
Message-ID: <87v9yixa1p.fsf@gnu.org> (raw)
In-Reply-To: <87a7fvfxcz.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Thu, 09 May 2019 17:42:20 +0200")
Heya,
Pierre Neidhardt <mail@ambrevar.xyz> skribis:
>>>>> guix: Simplify and robustify lzread!.
>>>> ^
>>>> Should be lzlib.
>>>
>>> Oops!
>>> I must confess that I never really understood the whole logic behind
>>> GNU-style commit message :p
>>
>> It’s really Guix-specific here, but the idea is that the word before
>> colon indicates the part of the code being modified, to provide a bit of
>> context.
>
> That makes sense. Where it makes less sense to me is when we prefix
> with "gnu:" for packages. Why GNU? Why not "packages:"?
Historical reasons. :-) Once upon a time that was “distro:”…
> No bug on an actual use case. I kept discussing with Antonio and he
> pointed out the potential issue. The solution occurred to me on a fresh
> sunny morning :D
Good. :-)
>> (I’m super cautious here but that’s because I spent countless hours
>> debugging code that used zlib and libbz2 and lzo in the past. :-))
>
> Yup, tell me about it... Took me weeks just to figure out basic
> (de)compression ;)
>
> But now that I have a better understanding of the library, I'm much more
> confident about the robustness and debugability of the bindings. Once
> things start adding up in your head, it's much more straightforward to
> see what goes wrong and how to fix it. (Stating the obvious here, but
> that's only true with good libraries, and lzlib is a good one.)
Alright, sounds good!
Thank you,
Ludo’.
prev parent reply other threads:[~2019-05-10 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190507164442.23834.73953@vcs0.savannah.gnu.org>
[not found] ` <20190507164443.0BEE2207FC@vcs0.savannah.gnu.org>
2019-05-08 9:52 ` 01/01: guix: Simplify and robustify lzread! Ludovic Courtès
2019-05-08 10:40 ` Pierre Neidhardt
2019-05-09 14:27 ` Ludovic Courtès
2019-05-09 15:42 ` Pierre Neidhardt
2019-05-10 21:40 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9yixa1p.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).