unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: guix: Simplify and robustify lzread!.
Date: Wed, 08 May 2019 11:52:27 +0200	[thread overview]
Message-ID: <87sgtp1des.fsf@gnu.org> (raw)
In-Reply-To: <20190507164443.0BEE2207FC@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Tue, 7 May 2019 12:44:42 -0400 (EDT)")

Hi Pierre!

guix-commits@gnu.org skribis:

> commit ecfc54403e2a1934b4f6e84ddad429b7970091fa
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date:   Tue May 7 18:40:40 2019 +0200
>
>     guix: Simplify and robustify lzread!.
      ^
Should be lzlib.

>     * guix/lzlib.scm (lzread!): Do it.
>     
>     Previously lzread! would fail if COUNT was bigger
>     than (lz-decompress-write-size).  This is possible if a previous call to
>     lzread! didn't empty the LZ_decompress input buffer (e.g. BV was too small to
>     fit all the data).

Could you add a test for this corner case?  It’s corner cases like that
that can spoil the whole experience, so it feels safer to add tests as
soon as we encounter them.  :-)

Thanks!

Ludo’.

       reply	other threads:[~2019-05-08  9:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190507164442.23834.73953@vcs0.savannah.gnu.org>
     [not found] ` <20190507164443.0BEE2207FC@vcs0.savannah.gnu.org>
2019-05-08  9:52   ` Ludovic Courtès [this message]
2019-05-08 10:40     ` 01/01: guix: Simplify and robustify lzread! Pierre Neidhardt
2019-05-09 14:27       ` Ludovic Courtès
2019-05-09 15:42         ` Pierre Neidhardt
2019-05-10 21:40           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgtp1des.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).