From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 01/01: guix: Simplify and robustify lzread!.
Date: Fri, 10 May 2019 23:40:50 +0200
Message-ID: <87v9yixa1p.fsf@gnu.org>
References: <20190507164442.23834.73953@vcs0.savannah.gnu.org>
	<20190507164443.0BEE2207FC@vcs0.savannah.gnu.org>
	<87sgtp1des.fsf@gnu.org> <8736lpxm8i.fsf@ambrevar.xyz>
	<87imujem9f.fsf@gnu.org> <87a7fvfxcz.fsf@ambrevar.xyz>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:50577)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1hPDG9-0005pH-Rn
	for guix-devel@gnu.org; Fri, 10 May 2019 17:40:54 -0400
In-Reply-To: <87a7fvfxcz.fsf@ambrevar.xyz> (Pierre Neidhardt's message of
	"Thu, 09 May 2019 17:42:20 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org

Heya,

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

>>>>>     guix: Simplify and robustify lzread!.
>>>>       ^
>>>> Should be lzlib.
>>>
>>> Oops!
>>> I must confess that I never really understood the whole logic behind
>>> GNU-style commit message :p
>>
>> It=E2=80=99s really Guix-specific here, but the idea is that the word be=
fore
>> colon indicates the part of the code being modified, to provide a bit of
>> context.
>
> That makes sense.  Where it makes less sense to me is when we prefix
> with "gnu:" for packages.  Why GNU?  Why not "packages:"?

Historical reasons.  :-)  Once upon a time that was =E2=80=9Cdistro:=E2=80=
=9D=E2=80=A6

> No bug on an actual use case.  I kept discussing with Antonio and he
> pointed out the potential issue.  The solution occurred to me on a fresh
> sunny morning :D

Good.  :-)

>> (I=E2=80=99m super cautious here but that=E2=80=99s because I spent coun=
tless hours
>> debugging code that used zlib and libbz2 and lzo in the past.  :-))
>
> Yup, tell me about it...  Took me weeks just to figure out basic
> (de)compression ;)
>
> But now that I have a better understanding of the library, I'm much more
> confident about the robustness and debugability of the bindings.  Once
> things start adding up in your head, it's much more straightforward to
> see what goes wrong and how to fix it.  (Stating the obvious here, but
> that's only true with good libraries, and lzlib is a good one.)

Alright, sounds good!

Thank you,
Ludo=E2=80=99.