unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: alacritty: Update to 0.7.1.
Date: Wed, 17 Feb 2021 11:56:55 +0100	[thread overview]
Message-ID: <87v9ar6jyg.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87wnv7wuzw.fsf@nckx> (Tobias Geerinckx-Rice's message of "Tue, 16 Feb 2021 22:41:39 +0100")

Hello,

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Are you sure Gnome 3 doesn't run X?

I don't know. I use Gnome 3 on Debian 10 and reports "Wayland" as
"Windowing system" (translation is mine).

OTOH, I know that some Wayland-specific applications, e.g., "wob",
refuse to run in it. So it might as well be an hybrid beast.

> I'd be suprised (and interested) if
>
>  DISPLAY= $(guix time-machine --commit=3e10f0e -- \
> 	build alacritty)/bin/alacritty
>
> works for you.  It should complain and fail to launch at all, because
> it can't connect to the legacy X(wayland) server.

The command above fails for me, indeed.

> I don't know.  Maybe more testing, or pinging the original author. No
> definitive answers here.

It's difficult to do more testing without knowing what to test. It is
a terminal emulator. I launched it and executed a couple of commands in
it.

Moreover, the original author hasn't updated the package since it was
added, a year ago. So I guess they were not interested in keeping it up
to date.

I'm not pretending the process could not be improved on my side. However
in this particular case, the improvements are not obvious. Also, on
complicated packages such as this one, I think some hiccups are going to
happen anyway. Yet, it is obviously better than not updating them at
all.

>> Please bear in mind that:
>> 1. it was not a small version bump, so many things could have
>> changed in
>>    the package definition;
>
> Right, I had to bump the version numbers, but it wasn't an
> unreasonable amount of work.

For large version bumps, I tend to discard old tweaks first and check if
the program runs without them. Otherwise, we might pile up cruft in
package definitions forever.

> Agreed on both counts: it's a gross hack[0], and it deserves
> a comment.  I should have added one and will do so now.

Thank you. 

It might also be interesting to add the command "DISPLAY= $(guix build
alacrity)/bin/alacritty" in the comment so anyone can try it out before
updating the package.

WDYT?

Regards,
-- 
Nicolas Goaziou


  reply	other threads:[~2021-02-17 10:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 14:42 [PATCH] gnu: alacritty: Update to 0.7.1 Tobias Geerinckx-Rice
2021-02-16 15:56 ` Tobias Geerinckx-Rice
2021-02-16 20:38 ` Nicolas Goaziou
2021-02-16 21:41   ` Tobias Geerinckx-Rice
2021-02-17 10:56     ` Nicolas Goaziou [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-02-17 12:49 John Soo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9ar6jyg.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=guix-devel@gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).