unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / Atom feed
* Re: [PATCH] gnu: alacritty: Update to 0.7.1.
@ 2021-02-16 14:42 Tobias Geerinckx-Rice
  2021-02-16 15:56 ` Tobias Geerinckx-Rice
  2021-02-16 20:38 ` Nicolas Goaziou
  0 siblings, 2 replies; 6+ messages in thread
From: Tobias Geerinckx-Rice @ 2021-02-16 14:42 UTC (permalink / raw)
  To: mail; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi Nicolas,

Commit 3e10f0eef0fb8b99f5220653b6564693365491b1 removes a phase:

> Remove unneeded phase and some replacements.

without explanation.  It's admittedly not the prettiest hack, but 
is needed to run Alacritty on Wayland[0].

Do you remember why you removed it?  (Please, say so in the commit 
message!)

Kind regards,

T G-R

[0]: http://logs.guix.gnu.org/guix/2021-02-16.log#150007

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: alacritty: Update to 0.7.1.
  2021-02-16 14:42 [PATCH] gnu: alacritty: Update to 0.7.1 Tobias Geerinckx-Rice
@ 2021-02-16 15:56 ` Tobias Geerinckx-Rice
  2021-02-16 20:38 ` Nicolas Goaziou
  1 sibling, 0 replies; 6+ messages in thread
From: Tobias Geerinckx-Rice @ 2021-02-16 15:56 UTC (permalink / raw)
  Cc: mail, guix-devel

[-- Attachment #1: Type: text/plain, Size: 98 bytes --]

Restored in 4390934f0b4a0d9208423e3b261e0f09b40eeb39 and it seems 
to work.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: alacritty: Update to 0.7.1.
  2021-02-16 14:42 [PATCH] gnu: alacritty: Update to 0.7.1 Tobias Geerinckx-Rice
  2021-02-16 15:56 ` Tobias Geerinckx-Rice
@ 2021-02-16 20:38 ` Nicolas Goaziou
  2021-02-16 21:41   ` Tobias Geerinckx-Rice
  1 sibling, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2021-02-16 20:38 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: guix-devel

Hello,

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Commit 3e10f0eef0fb8b99f5220653b6564693365491b1 removes a phase:
>
>> Remove unneeded phase and some replacements.
>
> without explanation.  It's admittedly not the prettiest hack, but is
> needed to run Alacritty on Wayland[0].
>
> Do you remember why you removed it?  (Please, say so in the commit
> message!)

As written in the commit message, I removed it because Alacritty was
working without it here on my Gnome 3 Wayland session, hence the
"unneeded" part. What else was necessary?

Please bear in mind that:
1. it was not a small version bump, so many things could have changed in
   the package definition;

2. the hack is actually non-trivial as it references packages that do
   not even belong to the inputs but was not even a single comment line
   explaining its importance.

I'm sorry if you lost time re-instating this hack. OTOH, there is
certainly room for improvement in this situation.

Regards,
-- 
Nicolas Goaziou


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: alacritty: Update to 0.7.1.
  2021-02-16 20:38 ` Nicolas Goaziou
@ 2021-02-16 21:41   ` Tobias Geerinckx-Rice
  2021-02-17 10:56     ` Nicolas Goaziou
  0 siblings, 1 reply; 6+ messages in thread
From: Tobias Geerinckx-Rice @ 2021-02-16 21:41 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1558 bytes --]

Hi!

Nicolas Goaziou 写道:
> As written in the commit message, I removed it because Alacritty 
> was
> working without it

Thank you.  That's more than I could infer from a terse ‘Remove 
unneeded phase’: you ran it on Wayland [see below] and it worked.

It's OK add rationales like this above the dry changelog (I 
mention it only because people have assumed the contrary).

> here on my Gnome 3 Wayland session, hence the "unneeded" part.

Are you sure Gnome 3 doesn't run X?

I'd be suprised (and interested) if

  DISPLAY= $(guix time-machine --commit=3e10f0e -- \
	build alacritty)/bin/alacritty

works for you.  It should complain and fail to launch at all, 
because it can't connect to the legacy X(wayland) server.

> What else was necessary?

I don't know.  Maybe more testing, or pinging the original author. 
No definitive answers here.

> Please bear in mind that:
> 1. it was not a small version bump, so many things could have 
> changed in
>    the package definition;

Right, I had to bump the version numbers, but it wasn't an 
unreasonable amount of work.

> 2. the hack is actually non-trivial as it references packages 
> that do
>    not even belong to the inputs but was not even a single 
>    comment line
>    explaining its importance.

Agreed on both counts: it's a gross hack[0], and it deserves a 
comment.  I should have added one and will do so now.

Kind regards,

T G-R

[0]: The alternative is stuffing both X libraries into 
LD_LIBRARY_PATH, which is grosser...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: alacritty: Update to 0.7.1.
  2021-02-16 21:41   ` Tobias Geerinckx-Rice
@ 2021-02-17 10:56     ` Nicolas Goaziou
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2021-02-17 10:56 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: guix-devel

Hello,

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Are you sure Gnome 3 doesn't run X?

I don't know. I use Gnome 3 on Debian 10 and reports "Wayland" as
"Windowing system" (translation is mine).

OTOH, I know that some Wayland-specific applications, e.g., "wob",
refuse to run in it. So it might as well be an hybrid beast.

> I'd be suprised (and interested) if
>
>  DISPLAY= $(guix time-machine --commit=3e10f0e -- \
> 	build alacritty)/bin/alacritty
>
> works for you.  It should complain and fail to launch at all, because
> it can't connect to the legacy X(wayland) server.

The command above fails for me, indeed.

> I don't know.  Maybe more testing, or pinging the original author. No
> definitive answers here.

It's difficult to do more testing without knowing what to test. It is
a terminal emulator. I launched it and executed a couple of commands in
it.

Moreover, the original author hasn't updated the package since it was
added, a year ago. So I guess they were not interested in keeping it up
to date.

I'm not pretending the process could not be improved on my side. However
in this particular case, the improvements are not obvious. Also, on
complicated packages such as this one, I think some hiccups are going to
happen anyway. Yet, it is obviously better than not updating them at
all.

>> Please bear in mind that:
>> 1. it was not a small version bump, so many things could have
>> changed in
>>    the package definition;
>
> Right, I had to bump the version numbers, but it wasn't an
> unreasonable amount of work.

For large version bumps, I tend to discard old tweaks first and check if
the program runs without them. Otherwise, we might pile up cruft in
package definitions forever.

> Agreed on both counts: it's a gross hack[0], and it deserves
> a comment.  I should have added one and will do so now.

Thank you. 

It might also be interesting to add the command "DISPLAY= $(guix build
alacrity)/bin/alacritty" in the comment so anyone can try it out before
updating the package.

WDYT?

Regards,
-- 
Nicolas Goaziou


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] gnu: alacritty: Update to 0.7.1.
@ 2021-02-17 12:49 John Soo
  0 siblings, 0 replies; 6+ messages in thread
From: John Soo @ 2021-02-17 12:49 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: Guix-Devel

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

      
  

  
  
  
Hey Tobias and Nicolás,  

  
I added alacritty some time ago but I do use it every day.    I don’t use Wayland (yet) though so I can’t say whether the hack in question is working. I can confirm that the update is just fine on X though.
  

  

  
Sorry for not keeping it more up to date!    I think the alacritty project itself has been slow to make releases, to be fair, though.    Thanks for taking a look at it!
  

  
- John
  
  
  
  

  
     

[-- Attachment #2: Type: text/html, Size: 651 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-17 12:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 14:42 [PATCH] gnu: alacritty: Update to 0.7.1 Tobias Geerinckx-Rice
2021-02-16 15:56 ` Tobias Geerinckx-Rice
2021-02-16 20:38 ` Nicolas Goaziou
2021-02-16 21:41   ` Tobias Geerinckx-Rice
2021-02-17 10:56     ` Nicolas Goaziou
2021-02-17 12:49 John Soo

unofficial mirror of guix-devel@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-devel/0 guix-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-devel guix-devel/ https://yhetil.org/guix-devel \
		guix-devel@gnu.org
	public-inbox-index guix-devel

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.devel
	nntp://news.gmane.io/gmane.comp.gnu.guix.devel


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git