From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: alacritty: Update to 0.7.1.
Date: Tue, 16 Feb 2021 21:38:52 +0100 [thread overview]
Message-ID: <874kibhhnn.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87im6sxef9.fsf@nckx> (Tobias Geerinckx-Rice's message of "Tue, 16 Feb 2021 15:42:02 +0100")
Hello,
Tobias Geerinckx-Rice <me@tobias.gr> writes:
> Commit 3e10f0eef0fb8b99f5220653b6564693365491b1 removes a phase:
>
>> Remove unneeded phase and some replacements.
>
> without explanation. It's admittedly not the prettiest hack, but is
> needed to run Alacritty on Wayland[0].
>
> Do you remember why you removed it? (Please, say so in the commit
> message!)
As written in the commit message, I removed it because Alacritty was
working without it here on my Gnome 3 Wayland session, hence the
"unneeded" part. What else was necessary?
Please bear in mind that:
1. it was not a small version bump, so many things could have changed in
the package definition;
2. the hack is actually non-trivial as it references packages that do
not even belong to the inputs but was not even a single comment line
explaining its importance.
I'm sorry if you lost time re-instating this hack. OTOH, there is
certainly room for improvement in this situation.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-02-17 1:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 14:42 [PATCH] gnu: alacritty: Update to 0.7.1 Tobias Geerinckx-Rice
2021-02-16 15:56 ` Tobias Geerinckx-Rice
2021-02-16 20:38 ` Nicolas Goaziou [this message]
2021-02-16 21:41 ` Tobias Geerinckx-Rice
2021-02-17 10:56 ` Nicolas Goaziou
-- strict thread matches above, loose matches on Subject: below --
2021-02-17 12:49 John Soo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kibhhnn.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).