Re: [PATCH] gnu: Add xulrunner and conkeror.

[ludo@gnu.org (Ludovic Courtès)]

Cyrill Schenkel <cyrill.schenkel@gmail.com> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>>> +  (package
>>> +    (name "conkeror")
>>> +    (version "1.0pre1")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> +              (uri
>>> +               (string-append "http://repo.or.cz/w/conkeror.git/snapshot/"
>>> +                              "8a26fff5896a3360549e2adfbf06b1d57e909266"
>>> +                              ".tar.gz"))
>>
>> Normally we provide only released versions.  If the last official
>> release is too old or broken, could you add a comment stating why we
>> take this one?
>
> This is the last tagged commit from the repository.

OK.

>>> +    (native-inputs `(("tar" ,tar)
>>> +                     ("gzip" ,gzip)))
>>
>> This should not be needed because these are implicit inputs.
>
> It is needed because the `trivial' build system is used.

Oh, right.

>>> +    (license (list license:gpl2
>>> +                   license:lgpl2.1))))
>>
>> Could you add a comment saying if this is dual-licensing, or something
>> else?  Also, did you mean ‘gpl2+’ and ‘lgpl2.1+’?
>
> Unfortunately they don't use the "or (at your option) any later version"
> clause:

OK.

> Alírio Eyng <alirioeyng@gmail.com> writes:
>
>> I use "abrowser -app conkeror/application.ini"; xulrunner isn't needed
>> at all, just a script...
>
> This approach is used now.

Perfect.

Pushed, thanks!

Ludo’.