Re: [PATCH] gnu: Add xulrunner and conkeror.

[ludo@gnu.org (Ludovic Courtès)]

Cyrill Schenkel <cyrill.schenkel@gmail.com> skribis:

> From 45e7d3afb7247c3fc82fb9d1b275254bde054911 Mon Sep 17 00:00:00 2001
> From: Cyrill Schenkel <cyrill.schenkel@gmail.com>
> Date: Sun, 6 Jul 2014 10:40:05 +0200
> Subject: [PATCH] gnu: Add xulrunner and conkeror.
>
> * gnu-system.am (GNU_SYSTEM_MODULES, dist_patch_DATA): Add new package and patch.
> * gnu/packages/conkeror.scm: New file.
> * gnu/packages/patches/xulrunner-install.patch: New file.
> * gnu/packages/xulrunner.scm: New file.

Wow, great!  This is among the last packages I regularly use that I missed.

[...]

> +  (package
> +    (name "conkeror")
> +    (version "1.0pre1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (string-append "http://repo.or.cz/w/conkeror.git/snapshot/"
> +                              "8a26fff5896a3360549e2adfbf06b1d57e909266"
> +                              ".tar.gz"))

Normally we provide only released versions.  If the last official
release is too old or broken, could you add a comment stating why we
take this one?

> +    (native-inputs `(("tar" ,tar)
> +                     ("gzip" ,gzip)))

This should not be needed because these are implicit inputs.

> +    (description " Conkeror is a highly-programmable web browser based on
                     ^
Extra space.

> +Mozilla XULRunner which is the base of all Mozilla products including
> +Firefox. Conkeror has a sophisticated keyboard system for running commands and
> +interacting with web page content, modelled after Emacs and Lynx. It is
> +self-documenting and extensible with JavaScript.
> +
> +It comes with builtin support for several Web 2.0 sites like several Google
> +services (Search, Gmail, Maps, Reader, etc.), Del.icio.us, Reddit, Last.fm and
> +YouTube. For easier editing of form fields, it can spawn external editors. For
> +this feature the recommended conkeror-spawn-process-helper package needs to be
> +installed.
> +
> +Despite its very similar sounding name, Conkeror is not related to the KDE web
> +browser and file manager Konqueror in any way. ")

If you could make it one paragraph shorter, that’d be great.

> +    (license (list license:gpl2
> +                   license:lgpl2.1))))

Could you add a comment saying if this is dual-licensing, or something
else?  Also, did you mean ‘gpl2+’ and ‘lgpl2.1+’?

If the result is a combination of GPLv2 and LGPLv2.1 files, then it
should be simply license:gpl2(+).

> --- /dev/null
> +++ b/gnu/packages/patches/xulrunner-install.patch

Please add a couple of lines saying what it does, and what the upstream
status is.

> +(define-module (gnu packages xulrunner)

This one looks good.  I’m wondering if it would make sense to take
xulrunner from the IceCat sources, but I’m not sure IceCat modifies
xulrunner itself.  Ideas?

Thank you!

Ludo’.