From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add xulrunner and conkeror.
Date: Tue, 08 Jul 2014 17:57:56 +0200
Message-ID: <87tx6rrgfv.fsf@gnu.org>
References: <87bnt2hnmp.fsf@gmail.com> <877g3qokqa.fsf@gnu.org>
	<87vbr9f6dn.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47986)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X4XmO-0002Om-1M
	for guix-devel@gnu.org; Tue, 08 Jul 2014 11:58:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1X4XmJ-0007S2-4i
	for guix-devel@gnu.org; Tue, 08 Jul 2014 11:58:03 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:37847)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1X4XmI-0007Ru-Tr
	for guix-devel@gnu.org; Tue, 08 Jul 2014 11:57:59 -0400
In-Reply-To: <87vbr9f6dn.fsf@gmail.com> (Cyrill Schenkel's message of "Mon, 07
	Jul 2014 19:03:48 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyrill Schenkel <cyrill.schenkel@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>

Cyrill Schenkel <cyrill.schenkel@gmail.com> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>>> +  (package
>>> +    (name "conkeror")
>>> +    (version "1.0pre1")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> +              (uri
>>> +               (string-append "http://repo.or.cz/w/conkeror.git/snapsh=
ot/"
>>> +                              "8a26fff5896a3360549e2adfbf06b1d57e90926=
6"
>>> +                              ".tar.gz"))
>>
>> Normally we provide only released versions.  If the last official
>> release is too old or broken, could you add a comment stating why we
>> take this one?
>
> This is the last tagged commit from the repository.

OK.

>>> +    (native-inputs `(("tar" ,tar)
>>> +                     ("gzip" ,gzip)))
>>
>> This should not be needed because these are implicit inputs.
>
> It is needed because the `trivial' build system is used.

Oh, right.

>>> +    (license (list license:gpl2
>>> +                   license:lgpl2.1))))
>>
>> Could you add a comment saying if this is dual-licensing, or something
>> else?  Also, did you mean =E2=80=98gpl2+=E2=80=99 and =E2=80=98lgpl2.1+=
=E2=80=99?
>
> Unfortunately they don't use the "or (at your option) any later version"
> clause:

OK.

> Al=C3=ADrio Eyng <alirioeyng@gmail.com> writes:
>
>> I use "abrowser -app conkeror/application.ini"; xulrunner isn't needed
>> at all, just a script...
>
> This approach is used now.

Perfect.

Pushed, thanks!

Ludo=E2=80=99.