* Re: branch core-updates updated: packages: Fix 'base32' used before definition warning.
[not found] <20210110222441.10557.47179@vcs0.savannah.gnu.org>
@ 2021-01-11 8:49 ` Ludovic Courtès
2021-01-11 13:16 ` Maxim Cournoyer
0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2021-01-11 8:49 UTC (permalink / raw)
To: guix-devel; +Cc: Maxim Cournoyer
Hi Maxim,
guix-commits@gnu.org skribis:
> commit 31ebecf73dadb51ccc72053f54dee36c93a2d0ab
> Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> AuthorDate: Sun Jan 10 08:42:42 2021 -0500
>
> packages: Fix 'base32' used before definition warning.
>
> Before this change, compiling the module would emit the following message:
> "guix/packages.scm:213:25: warning: macro `base32' used before definition".
>
> * guix/packages.scm (define-compile-time-decoder)
> (base32, base64): Move definitions to the top of the module.
To avoid merge conflicts down the road, could you apply it to ‘master’
as well? (It’s fine to have it on ‘master’ as it doesn’t trigger any
rebuild.)
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: branch core-updates updated: packages: Fix 'base32' used before definition warning.
2021-01-11 8:49 ` branch core-updates updated: packages: Fix 'base32' used before definition warning Ludovic Courtès
@ 2021-01-11 13:16 ` Maxim Cournoyer
0 siblings, 0 replies; 2+ messages in thread
From: Maxim Cournoyer @ 2021-01-11 13:16 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Hi Ludovic!
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Maxim,
>
> guix-commits@gnu.org skribis:
>
>> commit 31ebecf73dadb51ccc72053f54dee36c93a2d0ab
>> Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> AuthorDate: Sun Jan 10 08:42:42 2021 -0500
>>
>> packages: Fix 'base32' used before definition warning.
>>
>> Before this change, compiling the module would emit the following message:
>> "guix/packages.scm:213:25: warning: macro `base32' used before definition".
>>
>> * guix/packages.scm (define-compile-time-decoder)
>> (base32, base64): Move definitions to the top of the module.
>
> To avoid merge conflicts down the road, could you apply it to ‘master’
> as well? (It’s fine to have it on ‘master’ as it doesn’t trigger any
> rebuild.)
Thanks for letting me know; I was under the impression that the
guix/packages.scm module as a whole would be used in the computation of
any package's derivation hash. I'm happy to learn it's actually smarter
than this :-).
Cherry-picked to master with commit
8152fd1af551f4bcec2ef59243264c10ff48daea.
Thank you,
Maxim
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-11 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210110222441.10557.47179@vcs0.savannah.gnu.org>
2021-01-11 8:49 ` branch core-updates updated: packages: Fix 'base32' used before definition warning Ludovic Courtès
2021-01-11 13:16 ` Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).