From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qCxfA9VP/F9xEAAA0tVLHw (envelope-from ) for ; Mon, 11 Jan 2021 13:17:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mAjKOtRP/F8DSwAAB5/wlQ (envelope-from ) for ; Mon, 11 Jan 2021 13:17:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 968299402A8 for ; Mon, 11 Jan 2021 13:17:08 +0000 (UTC) Received: from localhost ([::1]:46868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyx4F-0004zO-Jc for larch@yhetil.org; Mon, 11 Jan 2021 08:17:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyx3l-0004xb-42 for guix-devel@gnu.org; Mon, 11 Jan 2021 08:16:41 -0500 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]:34767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyx3h-0004X6-Uv; Mon, 11 Jan 2021 08:16:36 -0500 Received: by mail-io1-xd32.google.com with SMTP id i18so17786228ioa.1; Mon, 11 Jan 2021 05:16:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=hAwYA6r8bhYztM3h5kHMt57tGtvpTVhArOmEBDp4MuY=; b=Q5KIbcq2Qj3oLk9AH76rrvYXVMuvPozus16Q0v6/pe2tu+wT9Au5IVeFZRDps7VD5e zQ34k/hqvimeFRMDN1f17hW6okQfTST/5OT3yuslmQhpu4QfSi985SwVPTiFkqtqvpPS /RBYvjRB5Ry31NzIE5uYmKYq5Ud+llksruDk8ehelxzW5RJW9WnrGu9Y3CDzB0I3pLd+ dTXfnykkS/Vou9lBDEW0YZtXmzd0q7H/bp70VZkqagF1N7rhpzyxhi2yHHU43odJgPxn RFjF02rPFizRgGUpbtXb5vSW/irtA2z57gdprZveg8Gc4gbyrhHSnwHJRMnADUXGZLia fh3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=hAwYA6r8bhYztM3h5kHMt57tGtvpTVhArOmEBDp4MuY=; b=EVz5FN1XHRTfqNvRRiL6oY3UmDgcoQjvQADpwenxW5uFq3VbXiVq+FGNzqtRNi00bd AU8piwEgTIbraAWg+r6DInpvoUw6pGXUD89bnWbhdTfu4WNvGBh7f128xPP9atqWXuny PcqAqmAyBFMIhJLbyU8xCBA+YpykkMPH1j8TtSQAI2IYCeONUwWoV76WXpyH45OBT4K7 LV4Y+oJ020lQVM+mciMmZ30KPrUg2ic2dKXsSC7Vs8ZmmQFQE7rWUIsTCtCF+/6WKkuy 1tAYXH93oOjMqgxKFBy2qYzoYe8WWvxv9PdkqcD1ZsTqgihk1oGTud+I7EUFiNGDgi8u O5Kg== X-Gm-Message-State: AOAM5330WQlE2qcd63i01Kle3P/LqoB/rR+AdA0Hmr8ykQJrjJHBkuc0 rIJWx2aNJuTE6VN/Ia31fp/CA4C1a+B2Uw== X-Google-Smtp-Source: ABdhPJxIIXybpBqL3tRv0l9ZJ83fZ7/oKYZorH87TNMRRBsTiZDnGiB5g9GOW4vbLshLv57hqm74Zg== X-Received: by 2002:a02:cf9a:: with SMTP id w26mr13879345jar.25.1610370992348; Mon, 11 Jan 2021 05:16:32 -0800 (PST) Received: from hurd (dsl-156-95.b2b2c.ca. [66.158.156.95]) by smtp.gmail.com with ESMTPSA id w9sm14714385ilq.43.2021.01.11.05.16.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 05:16:31 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: branch core-updates updated: packages: Fix 'base32' used before definition warning. References: <20210110222441.10557.47179@vcs0.savannah.gnu.org> <87wnwjg8oq.fsf@gnu.org> Date: Mon, 11 Jan 2021 08:16:30 -0500 In-Reply-To: <87wnwjg8oq.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 11 Jan 2021 09:49:09 +0100") Message-ID: <87turnobpt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::d32; envelope-from=maxim.cournoyer@gmail.com; helo=mail-io1-xd32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.05 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Q5KIbcq2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 968299402A8 X-Spam-Score: -3.05 X-Migadu-Scanner: scn1.migadu.com X-TUID: rB7j97yiNbdh Hi Ludovic! Ludovic Court=C3=A8s writes: > Hi Maxim, > > guix-commits@gnu.org skribis: > >> commit 31ebecf73dadb51ccc72053f54dee36c93a2d0ab >> Author: Maxim Cournoyer >> AuthorDate: Sun Jan 10 08:42:42 2021 -0500 >> >> packages: Fix 'base32' used before definition warning. >> >> Before this change, compiling the module would emit the following me= ssage: >> "guix/packages.scm:213:25: warning: macro `base32' used before defin= ition". >> >> * guix/packages.scm (define-compile-time-decoder) >> (base32, base64): Move definitions to the top of the module. > > To avoid merge conflicts down the road, could you apply it to =E2=80=98ma= ster=E2=80=99 > as well? (It=E2=80=99s fine to have it on =E2=80=98master=E2=80=99 as it= doesn=E2=80=99t trigger any > rebuild.) Thanks for letting me know; I was under the impression that the guix/packages.scm module as a whole would be used in the computation of any package's derivation hash. I'm happy to learn it's actually smarter than this :-). Cherry-picked to master with commit 8152fd1af551f4bcec2ef59243264c10ff48daea. Thank you, Maxim