From: ludo@gnu.org (Ludovic Courtès)
To: Deck Pickard <deck.r.pickard@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Hotfix (repeat)
Date: Sun, 23 Nov 2014 21:16:37 +0100 [thread overview]
Message-ID: <87sih965ay.fsf@gnu.org> (raw)
In-Reply-To: <CAJ41eew2NZtDfxO6g=LVKaF2gQSr=2yVXogDG9G5nGfUgvhJdw@mail.gmail.com> (Deck Pickard's message of "Sun, 23 Nov 2014 04:07:22 +0100")
Deck Pickard <deck.r.pickard@gmail.com> skribis:
> Because google sucks, this time attaching the patches...
Indeed, this is much better than the mangled HTML version. :-)
> From 5ad37d9ab4febcbec8bbae8f7c14d7a49683c771 Mon Sep 17 00:00:00 2001
> From: nebuli <nebu@kipple>
> Date: Sat, 22 Nov 2014 19:16:51 +0100
> Subject: [PATCH 1/4] store: default to serial "scheduler"
> Status: RO
> Content-Length: 1172
> Lines: 28
>
> * guix/store.scm (set-build-options): exchange default argument values
Applied.
> From 8e297904d80b39cd510ba0cced37acdb9b1aeb89 Mon Sep 17 00:00:00 2001
> From: nebuli <nebu@kipple>
> Date: Sat, 22 Nov 2014 19:58:24 +0100
> Subject: [PATCH 2/4] guix build: Add --max-jobs option (without handling
> code).
>
> * doc/guix.texi: Mention in the docs.
> * guix/scripts/build.scm: Extend (show-build-options-help) and
> (%standard-build-options) functions.
Applied; I adjusted guix.texi to use a description similar to that in
“Invoking guix-daemon”.
> From 49d5d2c5e60e10566b8e87ea7956e8775b1325bc Mon Sep 17 00:00:00 2001
> From: nebuli <nebu@kipple>
> Date: Sat, 22 Nov 2014 20:13:07 +0100
> Subject: [PATCH 3/4] guix: Add schedule module.
>
> * guix/schedule.scm: New file. To handle --cores and --max-jobs
> options in 'guix build'.
> * Makefile.am (MODULES): Add *this.
[...]
> +(define-module (guix schedule)
[...]
> From d22504209d43080d04d798c960bd29f3d4891bd4 Mon Sep 17 00:00:00 2001
> From: nebuli <nebu@kipple>
> Date: Sat, 22 Nov 2014 20:25:11 +0100
> Subject: [PATCH 4/4] guix build: Try to handle --cores and --max-jobs in a
[...]
> + (let ((sched (make-schedule-sane #:max-cores (assoc-ref opts 'cores)
> + #:max-jobs (assoc-ref opts 'max-jobs))))
> + (set-build-options store
> + #:keep-failed? (assoc-ref opts 'keep-failed?)
> + #:build-cores (schedule-max-cores sched)
> + #:max-build-jobs (schedule-max-jobs sched)
I’m not sure what the goal is. Should use be prevented from frying
their laptop even when that’s what they ask for? I don’t think so. :-)
WDYT?
Thank you!
Ludo’.
PS: I left “nebuli <nebu@kipple>” as the author of the commits under the
assumption that you preferred not to use your real name. If I
that’s not the case, make sure to configure Git to use the name you
want to see there.
next prev parent reply other threads:[~2014-11-23 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 3:07 [PATCH] Hotfix (repeat) Deck Pickard
2014-11-23 20:16 ` Ludovic Courtès [this message]
2014-11-23 20:49 ` Ludovic Courtès
2014-11-24 15:40 ` Deck Pickard
2014-11-25 21:41 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sih965ay.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=deck.r.pickard@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).