unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Deck Pickard <deck.r.pickard@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Hotfix (repeat)
Date: Mon, 24 Nov 2014 16:40:52 +0100	[thread overview]
Message-ID: <CAJ41eezu=NPqBEuEy76zWLr3QY3XQ0grq87Jw3JZX9fNDpjmLw@mail.gmail.com> (raw)
In-Reply-To: <87tx1p3amm.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]

On 23 Nov 2014 21:49, "Ludovic Courtès" <ludo@gnu.org> wrote:
>
> Deck Pickard <deck.r.pickard@gmail.com> skribis:
>
> > From 8e297904d80b39cd510ba0cced37acdb9b1aeb89 Mon Sep 17 00:00:00 2001
> > From: nebuli <nebu@kipple>
> > Date: Sat, 22 Nov 2014 19:58:24 +0100
> > Subject: [PATCH 2/4] guix build: Add --max-jobs option (without handling
> >  code).
> >
> > * doc/guix.texi: Mention in the docs.
> > * guix/scripts/build.scm: Extend (show-build-options-help) and
> >   (%standard-build-options) functions.
>
> Actually I had overlooked that this patch does nothing.   :-)
>
> Could you send an updated version that passes the right option to
> ‘set-build-options’?
>

No. Using '-c 0 -M 0' fails with cryptic message. On a four core system
"innocent" (and logically consistent, I mean, from the description of those
options, one expects the daemon to do some load balancing) '-c 4 -M 4' ends
up with the same annoying N^2 behaviour.

As it is now, not using one of the options leads to sub-optimal saturation
of the through-output by default. Not very impressive, if you want to
attract hackers who are willing to spend their time and resources to
actually build locally from source. After all it's the only way to test and
find possible bugs on a wide set of possible configurations.

If you want it right, either fix it yourself (and please think hard and
carefully what to put in '-from-commandline' function if you want to expose
both options to the user) or stop with the antics and apply the patch. I
can live with constant branch rebasing, but will end users appreciate their
machines locking up? I mean every "proper" Linux user is expected to tail
their logs...

Unimpressed,
drp
-- 
.sig place holder

[-- Attachment #2: Type: text/html, Size: 2159 bytes --]

  reply	other threads:[~2014-11-24 15:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-23  3:07 [PATCH] Hotfix (repeat) Deck Pickard
2014-11-23 20:16 ` Ludovic Courtès
2014-11-23 20:49 ` Ludovic Courtès
2014-11-24 15:40   ` Deck Pickard [this message]
2014-11-25 21:41     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ41eezu=NPqBEuEy76zWLr3QY3XQ0grq87Jw3JZX9fNDpjmLw@mail.gmail.com' \
    --to=deck.r.pickard@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).