From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Hotfix (repeat) Date: Sun, 23 Nov 2014 21:16:37 +0100 Message-ID: <87sih965ay.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsdaP-00012G-V1 for guix-devel@gnu.org; Sun, 23 Nov 2014 15:16:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XsdaK-0004bx-7i for guix-devel@gnu.org; Sun, 23 Nov 2014 15:16:45 -0500 Received: from hera.aquilenet.fr ([2a01:474::1]:37724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsdaK-0004bq-0E for guix-devel@gnu.org; Sun, 23 Nov 2014 15:16:40 -0500 In-Reply-To: (Deck Pickard's message of "Sun, 23 Nov 2014 04:07:22 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Deck Pickard Cc: guix-devel@gnu.org Deck Pickard skribis: > Because google sucks, this time attaching the patches... Indeed, this is much better than the mangled HTML version. :-) > From 5ad37d9ab4febcbec8bbae8f7c14d7a49683c771 Mon Sep 17 00:00:00 2001 > From: nebuli > Date: Sat, 22 Nov 2014 19:16:51 +0100 > Subject: [PATCH 1/4] store: default to serial "scheduler" > Status: RO > Content-Length: 1172 > Lines: 28 > > * guix/store.scm (set-build-options): exchange default argument values Applied. > From 8e297904d80b39cd510ba0cced37acdb9b1aeb89 Mon Sep 17 00:00:00 2001 > From: nebuli > Date: Sat, 22 Nov 2014 19:58:24 +0100 > Subject: [PATCH 2/4] guix build: Add --max-jobs option (without handling > code). > > * doc/guix.texi: Mention in the docs. > * guix/scripts/build.scm: Extend (show-build-options-help) and > (%standard-build-options) functions. Applied; I adjusted guix.texi to use a description similar to that in =E2=80=9CInvoking guix-daemon=E2=80=9D. > From 49d5d2c5e60e10566b8e87ea7956e8775b1325bc Mon Sep 17 00:00:00 2001 > From: nebuli > Date: Sat, 22 Nov 2014 20:13:07 +0100 > Subject: [PATCH 3/4] guix: Add schedule module. > > * guix/schedule.scm: New file. To handle --cores and --max-jobs > options in 'guix build'. > * Makefile.am (MODULES): Add *this. [...] > +(define-module (guix schedule) [...] > From d22504209d43080d04d798c960bd29f3d4891bd4 Mon Sep 17 00:00:00 2001 > From: nebuli > Date: Sat, 22 Nov 2014 20:25:11 +0100 > Subject: [PATCH 4/4] guix build: Try to handle --cores and --max-jobs in a [...] > + (let ((sched (make-schedule-sane #:max-cores (assoc-ref opts 'cores) > + #:max-jobs (assoc-ref opts 'max-jobs= )))) > + (set-build-options store > + #:keep-failed? (assoc-ref opts 'keep-failed?) > + #:build-cores (schedule-max-cores sched) > + #:max-build-jobs (schedule-max-jobs sched) I=E2=80=99m not sure what the goal is. Should use be prevented from frying their laptop even when that=E2=80=99s what they ask for? I don=E2=80=99t t= hink so. :-) WDYT? Thank you! Ludo=E2=80=99. PS: I left =E2=80=9Cnebuli =E2=80=9D as the author of the comm= its under the assumption that you preferred not to use your real name. If I that=E2=80=99s not the case, make sure to configure Git to use the name= you want to see there.