Re: [PATCH] gnu: Add Kerberos client service.

[ludo@gnu.org (Ludovic Courtès)]

John Darrington <jmd@gnu.org> skribis:

> * doc/guix.texi (Kerberos Services)[Krb5 Service]: New subsubheading.
> * gnu/services/kerberos.scm (krb5-service-type): New variable.
> * gnu/services/configuration.scm (configuration-field-serializer,
>   configuration-field-getter): Export variables.

[...]

> +@subsubheading Krb5 Service
> +
> +Programs using Kerberos client library packages normally

s/Kerberos client library packages/a Kerberos client library/

> +No keytab filea are provided by this service.  You must explicitly create these.
                 ^
Typo.

Also ``keytab'', since we don't know what that is.

> +(define (serialize-string/unset field-name val)
> +  (if (not (eq? val unset-field))
> +      (serialize-field* field-name val)))
> +
> +(define (serialize-integer/unset field-name val)
> +  (if (not (eq? val unset-field))
> +      (serialize-field* field-name val)))
> +
> +(define (serialize-boolean/unset field-name val)
> +  (if (not (eq? val unset-field))
> +      (serialize-field* field-name
> +                        (if val "true" "false"))))
> +

Please use ‘when’ or ‘unless’ for single-arm ‘if’ (there are other
occurrences of this further down in this file.)  It makes it clear that
this is for effect.

(At some point we should add an explicit ‘port’ parameter for these
serialize procedures.)

> +;; An end-point is an address such as "192.168.0.1"
> +;; or an address port pair ("string/unset.example.com" . 109)
> +(define (end-point? val)
> +  (or (string? val)
> +      (and (pair? val)
> +           (string? (car val))
> +           (integer? (cdr val)))))

See <https://lists.gnu.org/archive/html/guix-devel/2016-11/msg01252.html>.

> +(define (serialize-end-point field-name val)
> +  (serialize-field* field-name
> +                   (if (string? val)
> +                       ;; The [] are needed in the case of IPv6 addresses
> +                       (format #f "[~a]" val)
> +                       (format #f "[~a]:~a" (car val) (cdr val)))))

See <https://lists.gnu.org/archive/html/guix-devel/2016-11/msg01252.html>.

> +(define (serialize-space-separated-string-list/unset field-name val)
> +  (if (not (eq? val unset-field))
> +      (serialize-field* field-name (string-join val " "))))

‘unless’.

OK with all these changes.

In the future, could you write a short summary of the changes when you
submit a new revision of a patch, to make it easier to keep track of it?

Thanks,
Ludo’.