From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add Kerberos client service. Date: Sat, 03 Dec 2016 16:13:17 +0100 Message-ID: <87shq5avw2.fsf@gnu.org> References: <1480768049-18696-1-git-send-email-jmd@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDC0C-0006lq-2O for guix-devel@gnu.org; Sat, 03 Dec 2016 10:13:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDC08-0007jg-Rc for guix-devel@gnu.org; Sat, 03 Dec 2016 10:13:24 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDC08-0007jc-OS for guix-devel@gnu.org; Sat, 03 Dec 2016 10:13:20 -0500 In-Reply-To: <1480768049-18696-1-git-send-email-jmd@gnu.org> (John Darrington's message of "Sat, 3 Dec 2016 13:27:29 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org John Darrington skribis: > * doc/guix.texi (Kerberos Services)[Krb5 Service]: New subsubheading. > * gnu/services/kerberos.scm (krb5-service-type): New variable. > * gnu/services/configuration.scm (configuration-field-serializer, > configuration-field-getter): Export variables. [...] > +@subsubheading Krb5 Service > + > +Programs using Kerberos client library packages normally s/Kerberos client library packages/a Kerberos client library/ > +No keytab filea are provided by this service. You must explicitly creat= e these. ^ Typo. Also ``keytab'', since we don't know what that is. > +(define (serialize-string/unset field-name val) > + (if (not (eq? val unset-field)) > + (serialize-field* field-name val))) > + > +(define (serialize-integer/unset field-name val) > + (if (not (eq? val unset-field)) > + (serialize-field* field-name val))) > + > +(define (serialize-boolean/unset field-name val) > + (if (not (eq? val unset-field)) > + (serialize-field* field-name > + (if val "true" "false")))) > + Please use =E2=80=98when=E2=80=99 or =E2=80=98unless=E2=80=99 for single-ar= m =E2=80=98if=E2=80=99 (there are other occurrences of this further down in this file.) It makes it clear that this is for effect. (At some point we should add an explicit =E2=80=98port=E2=80=99 parameter f= or these serialize procedures.) > +;; An end-point is an address such as "192.168.0.1" > +;; or an address port pair ("string/unset.example.com" . 109) > +(define (end-point? val) > + (or (string? val) > + (and (pair? val) > + (string? (car val)) > + (integer? (cdr val))))) See . > +(define (serialize-end-point field-name val) > + (serialize-field* field-name > + (if (string? val) > + ;; The [] are needed in the case of IPv6 addresses > + (format #f "[~a]" val) > + (format #f "[~a]:~a" (car val) (cdr val))))) See . > +(define (serialize-space-separated-string-list/unset field-name val) > + (if (not (eq? val unset-field)) > + (serialize-field* field-name (string-join val " ")))) =E2=80=98unless=E2=80=99. OK with all these changes. In the future, could you write a short summary of the changes when you submit a new revision of a patch, to make it easier to keep track of it? Thanks, Ludo=E2=80=99.