Re: [PATCH] gnu: Add Kerberos client service.

[ludo@gnu.org (Ludovic Courtès)]

Hi!

John Darrington <jmd@gnu.org> skribis:

> * doc/guix.texi: New subsubheading: Krb5 Service
> * gnu/services/kerberos.scm: New variable: krb5-service-type.

Please see ‘git log’ on how to introduce new sections and variables.

> +@subsubheading Krb5 Service
> +
> +The krb5 service provides the configuration for Kerberos clients, using
> +the MIT implementation of the Kerberos protocol version@tie{}5.

Maybe add: “ (the @code{mit-krb5} package).”

Also it would be good to add one or two sentences of context, like:

  Programs using the client library of @code{mit-krb5} expect such
  configuration files in @file{/etc/something} and read them to set up
  their Kerberos frobbing thingie.  System administrators typically
  define the appropriate configuration based on the network's Kerberos
  foobar.

Well, something like that.  :-)

> +@defvr {Scheme Variable} krb5-service-type
> +A service type for Kerberos 5 clients.

s/Kerberos 5/@code{mit-krb5}/

> +@lisp
> +(service krb5-service-type (krb5-configuration
> +				(default-realm "EXAMPLE.COM")

Please move the ‘krb5-configuration’ to the next line where it will be
aligned below ‘krb5-service-type’.  This will ensure correct PDF/PS/DVI
output as well as below-80 Info lines.

> +@item @code{allow-weak-crypto?} (default: @code{#f})
> +If this flag is #t then services which only offer encryption algorithms

@code{#t}

> +(define-syntax define-configuration
> +  (lambda (stx)
> +    (define (id ctx part . parts)

Nack!  We already have two copies of that one, we won’t add a third
one.  :-)

Fortunately, Julien submitted a patch to factorize it, so hopefully you
can use the factorize ‘define-configuration’ in a day or two.

> +;; For a more detailed explanation of these fields see man 5 krb5.conf
> +(define-configuration krb5-realm
> +  (name
> +   (string #f)
> +   "The name of the realm.")

Really cool.

> +;;  LocalWords:  Guix

Maybe we can avoid that, but no big deal.

So OK with changes along these lines when Julien’s factorization has
landed.

Thank you!

Ludo’.