From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 01/01: guix: Simplify and robustify lzread!.
Date: Wed, 08 May 2019 11:52:27 +0200
Message-ID: <87sgtp1des.fsf@gnu.org>
References: <20190507164442.23834.73953@vcs0.savannah.gnu.org>
	<20190507164443.0BEE2207FC@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:52385)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1hOJFZ-0000K3-LC
	for guix-devel@gnu.org; Wed, 08 May 2019 05:52:34 -0400
In-Reply-To: <20190507164443.0BEE2207FC@vcs0.savannah.gnu.org>
	(guix-commits@gnu.org's message of "Tue, 7 May 2019 12:44:42 -0400
	(EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org

Hi Pierre!

guix-commits@gnu.org skribis:

> commit ecfc54403e2a1934b4f6e84ddad429b7970091fa
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date:   Tue May 7 18:40:40 2019 +0200
>
>     guix: Simplify and robustify lzread!.
      ^
Should be lzlib.

>     * guix/lzlib.scm (lzread!): Do it.
>=20=20=20=20=20
>     Previously lzread! would fail if COUNT was bigger
>     than (lz-decompress-write-size).  This is possible if a previous call=
 to
>     lzread! didn't empty the LZ_decompress input buffer (e.g. BV was too =
small to
>     fit all the data).

Could you add a test for this corner case?  It=E2=80=99s corner cases like =
that
that can spoil the whole experience, so it feels safer to add tests as
soon as we encounter them.  :-)

Thanks!

Ludo=E2=80=99.