unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] import: pypi: Detect inputs.
Date: Thu, 26 Mar 2015 14:15:36 +0100	[thread overview]
Message-ID: <87r3sbc32f.fsf@gnu.org> (raw)
In-Reply-To: <1427058301-19477-1-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Sun, 22 Mar 2015 22:05:01 +0100")

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * guix/import/pypi.scm (compute-inputs, guess-requirements): New procedures.

Just some superficial comments.  David, anything else?

> +(define (guix-hash-url filename)
> +  "Return the hash of FILENAME in nix-base32 format."
> +  (bytevector->nix-base32-string
> +   (call-with-input-file filename port-sha256)))

Please remove and use:

  (bytevector->nix-base32-string (file-sha256 file))

> +(define (guix-name name)

‘python->package-name’?  + docstring

Could you augment tests/pypi.scm with a test where dependencies are
parsed?

Thanks!

Ludo’.

  reply	other threads:[~2015-03-26 13:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07 23:51 [PATCH] import: pypi: detect requirements from requirements.txt Cyril Roelandt
2015-03-08  0:41 ` David Thompson
2015-03-22 21:05   ` [PATCH] import: pypi: Detect inputs Cyril Roelandt
2015-03-26 13:15     ` Ludovic Courtès [this message]
2015-03-27 12:36     ` David Thompson
2015-03-29 13:46       ` Ludovic Courtès
2015-06-04 22:56       ` Cyril Roelandt
2015-06-07 20:03         ` Ludovic Courtès
2015-06-15  1:25           ` Cyril Roelandt
2015-06-18 10:45             ` Amirouche Boubekki
2015-06-19 15:32               ` Christopher Allan Webber
2015-06-20 18:01                 ` Amirouche Boubekki
2015-06-21 20:56               ` Ludovic Courtès
2015-06-21 21:32                 ` Amirouche Boubekki
2015-06-23 21:04               ` Cyril Roelandt
2015-06-24 19:49                 ` Ludovic Courtès
2015-06-24 21:42                   ` Cyril Roelandt
2015-03-22 21:05   ` [PATCH] import: pypi: detect requirements from requirements.txt Cyril Roelandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3sbc32f.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=tipecaml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).