From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] import: pypi: Detect inputs.
Date: Thu, 26 Mar 2015 14:15:36 +0100
Message-ID: <87r3sbc32f.fsf@gnu.org>
References: <87y4n82udx.fsf@fsf.org>
	<1427058301-19477-1-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36910)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yb7dP-0004Xs-HV
	for guix-devel@gnu.org; Thu, 26 Mar 2015 09:15:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yb7dL-0005EF-DY
	for guix-devel@gnu.org; Thu, 26 Mar 2015 09:15:43 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44876)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Yb7dL-0005EA-B9
	for guix-devel@gnu.org; Thu, 26 Mar 2015 09:15:39 -0400
In-Reply-To: <1427058301-19477-1-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Sun, 22 Mar 2015 22:05:01 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * guix/import/pypi.scm (compute-inputs, guess-requirements): New procedur=
es.

Just some superficial comments.  David, anything else?

> +(define (guix-hash-url filename)
> +  "Return the hash of FILENAME in nix-base32 format."
> +  (bytevector->nix-base32-string
> +   (call-with-input-file filename port-sha256)))

Please remove and use:

  (bytevector->nix-base32-string (file-sha256 file))

> +(define (guix-name name)

=E2=80=98python->package-name=E2=80=99?  + docstring

Could you augment tests/pypi.scm with a test where dependencies are
parsed?

Thanks!

Ludo=E2=80=99.