unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Amirouche Boubekki <amirouche@hypermove.net>
Cc: guix-devel@gnu.org, guix-devel-bounces+amirouche=hypermove.net@gnu.org
Subject: Re: [PATCH] import: pypi: Detect inputs.
Date: Sun, 21 Jun 2015 22:56:03 +0200	[thread overview]
Message-ID: <87ioagpyqk.fsf@gnu.org> (raw)
In-Reply-To: <dcefa440e96b445bc3185f21b7f03629@hypermove.net> (Amirouche Boubekki's message of "Thu, 18 Jun 2015 12:45:41 +0200")

Amirouche Boubekki <amirouche@hypermove.net> skribis:

> If I'm not mistaken this patch relies only on the presence of
> requirements.txt. This is not a required file in python
> packaging. otherwise said, we miss a lot using this method. I think
> the best way to do that would be to:
>
> - download the package and extract it
> - create an environment (#)
> - create a virtual env with access to system site package of the
> environment (#)
> - enter the venv and install the package
> - use `pip freeze -l` to retrieve the full set of dependencies

Cyril, WDYT?

I’m not familiar with the details, but my feeling is that reading
requirements.txt is more lightweight, simpler, and more robust than what
you propose.

So I’d be inclined to apply Cyril’s patch ASAP.

Thanks,
Ludo’.

  parent reply	other threads:[~2015-06-21 20:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07 23:51 [PATCH] import: pypi: detect requirements from requirements.txt Cyril Roelandt
2015-03-08  0:41 ` David Thompson
2015-03-22 21:05   ` [PATCH] import: pypi: Detect inputs Cyril Roelandt
2015-03-26 13:15     ` Ludovic Courtès
2015-03-27 12:36     ` David Thompson
2015-03-29 13:46       ` Ludovic Courtès
2015-06-04 22:56       ` Cyril Roelandt
2015-06-07 20:03         ` Ludovic Courtès
2015-06-15  1:25           ` Cyril Roelandt
2015-06-18 10:45             ` Amirouche Boubekki
2015-06-19 15:32               ` Christopher Allan Webber
2015-06-20 18:01                 ` Amirouche Boubekki
2015-06-21 20:56               ` Ludovic Courtès [this message]
2015-06-21 21:32                 ` Amirouche Boubekki
2015-06-23 21:04               ` Cyril Roelandt
2015-06-24 19:49                 ` Ludovic Courtès
2015-06-24 21:42                   ` Cyril Roelandt
2015-03-22 21:05   ` [PATCH] import: pypi: detect requirements from requirements.txt Cyril Roelandt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ioagpyqk.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=amirouche@hypermove.net \
    --cc=guix-devel-bounces+amirouche=hypermove.net@gnu.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).