* Re: 01/05: gnu: guix: Provide the correct version string. [not found] ` <20171128142056.58FDC20C81@vcs0.savannah.gnu.org> @ 2017-11-29 1:34 ` Mark H Weaver 2017-11-30 10:17 ` Ludovic Courtès 0 siblings, 1 reply; 2+ messages in thread From: Mark H Weaver @ 2017-11-29 1:34 UTC (permalink / raw) To: Ludovic Courtès; +Cc: guix-devel ludo@gnu.org (Ludovic Courtès) writes: > civodul pushed a commit to branch master > in repository guix. > > commit 91c619ebdfd065f0becbbcc742dc412dc41e77a1 > Author: Ludovic Courtès <ludo@gnu.org> > Date: Tue Nov 28 13:25:04 2017 +0100 > > gnu: guix: Provide the correct version string. > > Fixes <https://bugs.gnu.org/29429>. > Reported by Arun Isaac <arunisaac@systemreboot.net>. > > * gnu/packages/package-management.scm (guix)[arguments]: Move > 'bootstrap' phase before 'configure'. Create '.tarball-version' file. > --- > gnu/packages/package-management.scm | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm > index 15c310d..6d18fa0 100644 > --- a/gnu/packages/package-management.scm > +++ b/gnu/packages/package-management.scm > @@ -136,13 +136,17 @@ > (ice-9 rdelim)) > > #:phases (modify-phases %standard-phases > - (add-after 'unpack 'bootstrap > + (add-before 'configure 'bootstrap This change works directly against my efforts to move all of these 'bootstrap' phases after 'unpack' instead of before 'configure'. This ordering is important because on some systems, e.g. mips64el-linux, it's important for the 'patch-usr-bin-file' phase to fix the generated autoconf scripts. As I vaguely recall, on some systems, autoconf generates calls to '/usr/bin/file' to determine the ABI of compiled binaries. Can we fix this issue in another way? Mark ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 01/05: gnu: guix: Provide the correct version string. 2017-11-29 1:34 ` 01/05: gnu: guix: Provide the correct version string Mark H Weaver @ 2017-11-30 10:17 ` Ludovic Courtès 0 siblings, 0 replies; 2+ messages in thread From: Ludovic Courtès @ 2017-11-30 10:17 UTC (permalink / raw) To: Mark H Weaver; +Cc: guix-devel Hi Mark, Mark H Weaver <mhw@netris.org> skribis: > ludo@gnu.org (Ludovic Courtès) writes: > >> civodul pushed a commit to branch master >> in repository guix. >> >> commit 91c619ebdfd065f0becbbcc742dc412dc41e77a1 >> Author: Ludovic Courtès <ludo@gnu.org> >> Date: Tue Nov 28 13:25:04 2017 +0100 >> >> gnu: guix: Provide the correct version string. >> >> Fixes <https://bugs.gnu.org/29429>. >> Reported by Arun Isaac <arunisaac@systemreboot.net>. >> >> * gnu/packages/package-management.scm (guix)[arguments]: Move >> 'bootstrap' phase before 'configure'. Create '.tarball-version' file. >> --- >> gnu/packages/package-management.scm | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm >> index 15c310d..6d18fa0 100644 >> --- a/gnu/packages/package-management.scm >> +++ b/gnu/packages/package-management.scm >> @@ -136,13 +136,17 @@ >> (ice-9 rdelim)) >> >> #:phases (modify-phases %standard-phases >> - (add-after 'unpack 'bootstrap >> + (add-before 'configure 'bootstrap > > This change works directly against my efforts to move all of these > 'bootstrap' phases after 'unpack' instead of before 'configure'. This > ordering is important because on some systems, e.g. mips64el-linux, it's > important for the 'patch-usr-bin-file' phase to fix the generated > autoconf scripts. As I vaguely recall, on some systems, autoconf > generates calls to '/usr/bin/file' to determine the ABI of compiled > binaries. Right, thanks for the reminder. > Can we fix this issue in another way? Done in 8833a647bbe444b7a981d0ff977f8132b7d6fddb. Ludo’. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-30 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20171128142055.6989.80790@vcs0.savannah.gnu.org>
[not found] ` <20171128142056.58FDC20C81@vcs0.savannah.gnu.org>
2017-11-29 1:34 ` 01/05: gnu: guix: Provide the correct version string Mark H Weaver
2017-11-30 10:17 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).