Re: 01/05: gnu: guix: Provide the correct version string.

Re: 01/05: gnu: guix: Provide the correct version string.

[Mark H Weaver]

ludo@gnu.org (Ludovic Courtès) writes:

> civodul pushed a commit to branch master
> in repository guix.
>
> commit 91c619ebdfd065f0becbbcc742dc412dc41e77a1
> Author: Ludovic Courtès <ludo@gnu.org>
> Date:   Tue Nov 28 13:25:04 2017 +0100
>
>     gnu: guix: Provide the correct version string.
>     
>     Fixes <https://bugs.gnu.org/29429>.
>     Reported by Arun Isaac <arunisaac@systemreboot.net>.
>     
>     * gnu/packages/package-management.scm (guix)[arguments]: Move
>     'bootstrap' phase before 'configure'.  Create '.tarball-version' file.
> ---
>  gnu/packages/package-management.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
> index 15c310d..6d18fa0 100644
> --- a/gnu/packages/package-management.scm
> +++ b/gnu/packages/package-management.scm
> @@ -136,13 +136,17 @@
>                      (ice-9 rdelim))
>  
>           #:phases (modify-phases %standard-phases
> -                    (add-after 'unpack 'bootstrap
> +                    (add-before 'configure 'bootstrap

This change works directly against my efforts to move all of these
'bootstrap' phases after 'unpack' instead of before 'configure'.  This
ordering is important because on some systems, e.g. mips64el-linux, it's
important for the 'patch-usr-bin-file' phase to fix the generated
autoconf scripts.  As I vaguely recall, on some systems, autoconf
generates calls to '/usr/bin/file' to determine the ABI of compiled
binaries.

Can we fix this issue in another way?

      Mark

Re: 01/05: gnu: guix: Provide the correct version string.

[Ludovic Courtès]

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> civodul pushed a commit to branch master
>> in repository guix.
>>
>> commit 91c619ebdfd065f0becbbcc742dc412dc41e77a1
>> Author: Ludovic Courtès <ludo@gnu.org>
>> Date:   Tue Nov 28 13:25:04 2017 +0100
>>
>>     gnu: guix: Provide the correct version string.
>>     
>>     Fixes <https://bugs.gnu.org/29429>.
>>     Reported by Arun Isaac <arunisaac@systemreboot.net>.
>>     
>>     * gnu/packages/package-management.scm (guix)[arguments]: Move
>>     'bootstrap' phase before 'configure'.  Create '.tarball-version' file.
>> ---
>>  gnu/packages/package-management.scm | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
>> index 15c310d..6d18fa0 100644
>> --- a/gnu/packages/package-management.scm
>> +++ b/gnu/packages/package-management.scm
>> @@ -136,13 +136,17 @@
>>                      (ice-9 rdelim))
>>  
>>           #:phases (modify-phases %standard-phases
>> -                    (add-after 'unpack 'bootstrap
>> +                    (add-before 'configure 'bootstrap
>
> This change works directly against my efforts to move all of these
> 'bootstrap' phases after 'unpack' instead of before 'configure'.  This
> ordering is important because on some systems, e.g. mips64el-linux, it's
> important for the 'patch-usr-bin-file' phase to fix the generated
> autoconf scripts.  As I vaguely recall, on some systems, autoconf
> generates calls to '/usr/bin/file' to determine the ABI of compiled
> binaries.

Right, thanks for the reminder.

> Can we fix this issue in another way?

Done in 8833a647bbe444b7a981d0ff977f8132b7d6fddb.

Ludo’.