Re: branch master updated: services: cuirass: Add a no-publish argument.

Re: branch master updated: services: cuirass: Add a no-publish argument.

[Ludovic Courtès]

Hi!

guix-commits@gnu.org skribis:

> commit d128c6fd33f46ec4e2d0ef352d20a858c377bf6f
> Author: Mathieu Othacehe <othacehe@gnu.org>
> AuthorDate: Thu Aug 12 12:58:34 2021 +0200
>
>     services: cuirass: Add a no-publish argument.
>     
>     * gnu/services/cuirass.scm (<cuirass-remote-server-configuration>): Add a
>     no-publish? field.
>     (cuirass-shepherd-service): Honor it.
>     * doc/guix.texi (Cuirass remote building): Document it.

[...]

> +++ b/gnu/services/cuirass.scm
> @@ -72,6 +72,8 @@
>                      (default "/var/log/cuirass-remote-server.log"))
>    (cache            cuirass-remote-server-configuration-cache ;string
>                      (default "/var/cache/cuirass/remote/"))
> +  (no-publish?      cuirass-remote-server-configuration-no-publish? ;boolean
> +                    (default #f))

Nitpick: as a rule of thumb, I personally avoid negative options,
otherwise discussions easily end up with phrases like “disable
no-publish” and then you have to think twice before you’re confident
about the meaning.  :-)

So I’d suggest turning that into ‘publish?’, defaulting to #t.

Ludo’.

Re: branch master updated: services: cuirass: Add a no-publish argument.

[Mathieu Othacehe]

Hey,

> So I’d suggest turning that into ‘publish?’, defaulting to #t.

Yeah, you're completely right, I reversed the logic with:
cfd2442488971420289a12d5ca8f07816e1149bf.

Thanks,

Mathieu