From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: branch master updated: services: cuirass: Add a no-publish argument.
Date: Thu, 12 Aug 2021 23:22:53 +0200 [thread overview]
Message-ID: <87sfzegxxu.fsf@gnu.org> (raw)
In-Reply-To: <20210812110850.6645.33726@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Thu, 12 Aug 2021 07:08:50 -0400")
Hi!
guix-commits@gnu.org skribis:
> commit d128c6fd33f46ec4e2d0ef352d20a858c377bf6f
> Author: Mathieu Othacehe <othacehe@gnu.org>
> AuthorDate: Thu Aug 12 12:58:34 2021 +0200
>
> services: cuirass: Add a no-publish argument.
>
> * gnu/services/cuirass.scm (<cuirass-remote-server-configuration>): Add a
> no-publish? field.
> (cuirass-shepherd-service): Honor it.
> * doc/guix.texi (Cuirass remote building): Document it.
[...]
> +++ b/gnu/services/cuirass.scm
> @@ -72,6 +72,8 @@
> (default "/var/log/cuirass-remote-server.log"))
> (cache cuirass-remote-server-configuration-cache ;string
> (default "/var/cache/cuirass/remote/"))
> + (no-publish? cuirass-remote-server-configuration-no-publish? ;boolean
> + (default #f))
Nitpick: as a rule of thumb, I personally avoid negative options,
otherwise discussions easily end up with phrases like “disable
no-publish” and then you have to think twice before you’re confident
about the meaning. :-)
So I’d suggest turning that into ‘publish?’, defaulting to #t.
Ludo’.
next parent reply other threads:[~2021-08-12 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210812110850.6645.33726@vcs0.savannah.gnu.org>
2021-08-12 21:22 ` Ludovic Courtès [this message]
2021-08-13 11:48 ` branch master updated: services: cuirass: Add a no-publish argument Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfzegxxu.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).