Re: [PATCH] gnu: agg: New variable.

[ludo@gnu.org (Ludovic Courtès)]

Tomáš Čech <sleep_walker@gnu.org> skribis:

> * gnu/packages/graphics.scm (agg): New variable.

Please adjust the commit’s subject line as Andreas suggested.

> +              (uri (string-append "http://www.antigrain.com/agg-"
> +                                  version ".tar.gz"))
> +              (sha256 (base32
> +                       "07wii4i824vy9qsvjsgqxppgqmfdxq0xa87i5yk53fijriadq7mb"))

Maybe put ‘base32’ on the next line, as is done in the rest of this file
an elsewhere.

> +              (patches (list (search-patch "am_c_prototype.patch")
> +                             (search-patch
> +                              "antigrain-geometry-no_rpath.patch")))))

Please add these two patches to the patch, and list them in
gnu-system.am.

> +       (alist-cons-after
> +        'unpack 'autoreconf
> +        (lambda _
> +          ;; let's call configure from configure phase and not now
> +          (substitute* "autogen.sh" (("./configure") "# ./configure"))
> +          (zero? (system* "sh" "autogen.sh")))

So the tarball they provide is not generated from ‘make dist’?  Bah.

> +    (synopsis "A high quality rendering engine for C++")

“High-quality 2D graphics rendering engine for C++”

> +    (description
> +     "Anti-Grain Geometry is high quality rendering engine written in C++.  It
                              ^^^
“is a high-quality”

> +supports sub pixel resolutions and anti-aliasing.  It is also library for

“sub-pixel”

> +rendering SVG graphics")

Add missing period.

OK to push with these changes.

Thank you!

Ludo’.