From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: agg: New variable. Date: Tue, 17 Mar 2015 10:10:56 +0100 Message-ID: <87pp88ouov.fsf@gnu.org> References: <1426497311-25364-1-git-send-email-sleep_walker@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXnWg-0006ZA-1y for guix-devel@gnu.org; Tue, 17 Mar 2015 05:11:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXnWc-0007WV-QD for guix-devel@gnu.org; Tue, 17 Mar 2015 05:11:01 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXnWc-0007WR-NR for guix-devel@gnu.org; Tue, 17 Mar 2015 05:10:58 -0400 In-Reply-To: <1426497311-25364-1-git-send-email-sleep_walker@gnu.org> (=?utf-8?B?IlRvbcOhxaEJxIxlY2giJ3M=?= message of "Mon, 16 Mar 2015 10:15:11 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Cc: guix-devel@gnu.org Tom=C3=A1=C5=A1 =C4=8Cech skribis: > * gnu/packages/graphics.scm (agg): New variable. Please adjust the commit=E2=80=99s subject line as Andreas suggested. > + (uri (string-append "http://www.antigrain.com/agg-" > + version ".tar.gz")) > + (sha256 (base32 > + "07wii4i824vy9qsvjsgqxppgqmfdxq0xa87i5yk53fijriad= q7mb")) Maybe put =E2=80=98base32=E2=80=99 on the next line, as is done in the rest= of this file an elsewhere. > + (patches (list (search-patch "am_c_prototype.patch") > + (search-patch > + "antigrain-geometry-no_rpath.patch"))))) Please add these two patches to the patch, and list them in gnu-system.am. > + (alist-cons-after > + 'unpack 'autoreconf > + (lambda _ > + ;; let's call configure from configure phase and not now > + (substitute* "autogen.sh" (("./configure") "# ./configure")) > + (zero? (system* "sh" "autogen.sh"))) So the tarball they provide is not generated from =E2=80=98make dist=E2=80= =99? Bah. > + (synopsis "A high quality rendering engine for C++") =E2=80=9CHigh-quality 2D graphics rendering engine for C++=E2=80=9D > + (description > + "Anti-Grain Geometry is high quality rendering engine written in C+= +. It ^^^ =E2=80=9Cis a high-quality=E2=80=9D > +supports sub pixel resolutions and anti-aliasing. It is also library for =E2=80=9Csub-pixel=E2=80=9D > +rendering SVG graphics") Add missing period. OK to push with these changes. Thank you! Ludo=E2=80=99.